-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update "github.com/fsouza/go-dockerclient" #4428
Comments
Hi @onlyjob! I was curious why you cared whether we used tagged release or arbitrary commits until I noticed you're also the maintainer of the Either way this is a reasonable request we'll try to address. Just wondering what the root cause is. Hopefully in a year or two |
Yes, that's me, maintainer of Nomad in Debian. Yes, we are packaging most dependencies as individual (reusable) packages. Unfortunately Hashicorp makes it very difficult due to systematic abuse of good versioning practices. Only few Hashicorp libraries (e.g. Although I've noticed I do hope that vgo will eventually improve versioning in Golang ecosystem. But in the meantime we can improve a lot by consistent semantic versioning whenever possible. Thank you. |
Nomad 0.8.4 is in Debian now. :) |
Even in 0.10.1 this is still an issue. Currently sloppy-vendored |
Closed by #7550 |
I'm going to lock this issue because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active issues. |
github.com/fsouza/go-dockerclient is a semantically versioned library that should be vendored by release tag instead of a random commit.
Please update vendored
github.com/fsouza/go-dockerclient
by tag.Thanks.
The text was updated successfully, but these errors were encountered: