Option to prevent removal of container on exit #4535
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schmichael
reviewed
Jul 26, 2018
| @@ -1974,8 +1981,12 @@ func (h *DockerHandle) run() { | |||
| } | |||
|
|
|||
| // Remove the container | |||
| if err := h.client.RemoveContainer(docker.RemoveContainerOptions{ID: h.containerID, RemoveVolumes: true, Force: true}); err != nil { | |||
| h.logger.Printf("[ERR] driver.docker: error removing container: %v", err) | |||
| if h.removeContainerOnExit == true { | |||
| @@ -645,6 +645,10 @@ options](/docs/agent/configuration/client.html#options): | |||
| tasks using `cap_add` and `cap_drop` options. Supports the value `"ALL"` as a | |||
| shortcut for whitelisting all capabilities. | |||
|
|
|||
| * `docker.cleanup.container`: Defaults to `true`. This option can be used to | |||
| disable Nomad from removing a container when the task exits. Under a name | |||
| conflict, Nomad may still remove the dead container. | |||
There was a problem hiding this comment.
If set to false it is up to operators to periodically remove containers or risk running out of disk space.
Periodic system jobs would be perfect here
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.