UI: Job Writes #4600
Merged
UI: Job Writes #4600
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By default, blocks have a margin of 1.5em to create a consistent vertical rhythm. However, sometimes elements need to be associated with the element above them. In this cases, the gap between elements needs to be tighter. There are many ways to do this, but this approach asks the latter content to be marked as associative. The implication is that the association is with the previous block.
This has bit me more than once. It's best just to make Mirage consistent with the API even if it currently means indeterminate job ids
UI: Run a job from the Web UI
The lowest valid blocking query index is 1, but the API will return 0 if there has yet to be an index set (no response). This in conjunction with that 0 being stored as a string made the "fallback to 1" guard not work.
Caused by the re-indexing that occurs to remove zero-value bars.
Instead it was using the page-layout is-right div
…eeded This exports a function that returns the pertinent function when given a container. This way it works in registerHelper and in integration tests beforeEach hooks
Most of this was ported over from the existing job run acceptance tests
UI: New job improved plan screen
This was referenced Aug 23, 2018
Merged
Merged
…tton Before it would say the deployment required promotion, now it has a button that triggers the promotion.
UI: Edit a job
When the server doesn't respond immediately, there is a visible window of time between the action being submitted and the blocking query coming back with the new job status.
UI: Promote canary
UI: Restart stopped job
|
This is all buttoned up. Each piece was reviewed independently and tests still pass, so this is good to merge 🚀 |
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A multi-pr project to bring more write operations to the UI.