-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nomad 0.8.4 panics when talking to vault 0.11.0 #4633
Comments
Nomad needs to pull in updated API libs |
This doesn't seem to be a 0.11 bug. It appears to be this: hashicorp/vault#4553 which was fixed in Vault 0.10.2. This, however, appears to be after Nomad last pulled Vault API libs. We'll put in a workaround for 0.11.1 but Nomad should pull in updated API libs. |
May be problem is not only in hashicorp/vault#4553? I dumped request/response in this case. Request:
In curl form
Response on this request is
So, as you can see - there is exists "capabilities" key in response - in "data" subkey. And fix in https://github.com/hashicorp/vault/pull/4553/files do
And this code not fully fixed the problem - it try to get key from wrong response path. May be this is misunderstanding with Vault team and response format? |
I'm also having this issue! I'm a little worried that if my nomad servers restart for whatever reason then they aren't going to come back. So it sounds like updating the vault libs alone doesn't fix the issue? |
@adamlc I fixed it in file sys_capabilities.go and use nomad version with this patch |
@kak-tus thanks I'll give it a try! |
I can confirm the above fix is working perfectly :) |
I'm going to lock this issue because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active issues. |
Nomad version
Nomad v0.8.4 (dbee1d7)
Operating system and Environment details
Raspbian linux
Issue
Nomad panics when trying to access the vault api
Reproduction steps
Run nomad agent in server mode and connect with a vault 0.11.0 cluster
Nomad Server logs (if appropriate)
I think this needs a fix in the vault code, but posting here for completeness and follow up.
The text was updated successfully, but these errors were encountered: