docklog: add go-plugin for forwarding of docker logs #4758
Conversation
drivers/docker/docklog/docklog.go
Outdated
|
|
||
| // Docklog is a small utility to forward logs from a docker container to a target | ||
| // destination | ||
| type Docklog interface { |
There was a problem hiding this comment.
Not a huge fan of the name. Would call it DockerLogger
drivers/docker/docklog/docklog.go
Outdated
|
|
||
| // NewDocklog returns an implementation of the Docklog interface | ||
| func NewDocklog(logger hclog.Logger) Docklog { | ||
| return &dockerLogger{logger: logger} |
There was a problem hiding this comment.
Name the logger here, that has been the pattern elsewhere?
| require.NoError(err) | ||
|
|
||
| var count int | ||
| for !container.State.Running { |
There was a problem hiding this comment.
Could replace this with testutil.WaitForResult
| count++ | ||
| } | ||
|
|
||
| stdout := &noopCloser{bytes.NewBufferString("")} |
There was a problem hiding this comment.
https://golang.org/pkg/bytes/#NewBuffer and pass nil
| echoToContainer(t, client, container.ID, "abc") | ||
| echoToContainer(t, client, container.ID, "123") | ||
|
|
||
| time.Sleep(2000 * time.Millisecond) |
There was a problem hiding this comment.
This is a long sleep, why not just rely on wait for result?
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
This PR implements a go-plugin for forwarding the logs of a docker container which will be launched by the docker task driver plugin.