Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consul Support for HTTPS Addresses and Token #484

Closed
bluk opened this issue Nov 22, 2015 · 4 comments
Closed

Consul Support for HTTPS Addresses and Token #484

bluk opened this issue Nov 22, 2015 · 4 comments

Comments

@bluk
Copy link
Contributor

bluk commented Nov 22, 2015

I've set the consul.address for service discovery, but it seems that HTTPS scheme is not supported for Consul connections.

  "client": {
    "enabled": true,
    "servers": [ "192.168.1.100" ],
    "options": {
      "consul.address": "192.168.1.100:8501"
    }
  },

Startup logs have something like:

2015/11/22 16:16:30 [ERROR] consul: Error while registering service ServiceName with Consul: Put http://192.168.1.100:8501/v1/agent/service/register: malformed HTTP response "\x15\x03\x01\x00\x02\x02"

I imagine that Consul token support is also necessary at some point.

@diptanu
Copy link
Contributor

diptanu commented Nov 25, 2015

@bluk We are using the Consul api client, I think it uses http by default. Let me see how we can do https with it.

@diptanu
Copy link
Contributor

diptanu commented Nov 25, 2015

@bluk Looks like the API client supports https via the Scheme parameter https://github.com/hashicorp/consul/blob/master/api/api.go#L157

We will add an option to support http very soon in the consul config, and until then if you set up the environment variables CONSUL_HTTP_SSL and CONSUL_HTTP_SSL_VERIFY via the Jobs DSL the current code should be able to do https since it appears that the client is reading those environment variables.

@bluk
Copy link
Contributor Author

bluk commented Nov 25, 2015

@diptanu Thanks!

@github-actions
Copy link

I'm going to lock this issue because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants