Pass service metadata "external-source" for consul UI integration #4889
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jippi
reviewed
Jan 29, 2019
| @@ -566,6 +566,10 @@ func (c *ServiceClient) RegisterAgent(role string, services []*structs.Service) | |||
| Tags: service.Tags, | |||
| Address: host, | |||
| Port: port, | |||
| // This enables the consul UI to show that Nomad registered this service | |||
| Meta: map[string]string{ | |||
| "external-source": "nomad", | |||
There was a problem hiding this comment.
@preetapan would it be possible to have the nomad alloc ID in this meta key set as well? would be some of my work 1000x easier at work when trying to map nomad service{} to consul service id outside of nomad
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This lets the Consul UI show a little Nomad logo on services that Nomad registers.