UI: Faceted search on the jobs list page #5236

DingoEatingFuzz · 2019-01-24T19:07:16Z

This is part two of three for faceted search in the Nomad UI: #5235

Faceted search on the Jobs page introduces four quick filter options for finding jobs.

Type: Batch, Parameterized, Periodic, Service, or System
Status: Pending, Running, or Dead
Datacener: A dynamically built list for filtering jobs by which datacenters they are allowed to run in
Prefix: An experimental facet that dynamically builds a list based on common job name prefixes (beginning of name up to first -, _, or .)

Facet selections are persisted in query params in order to be shareable and bookmarkable.

johncowen

Hey 👋

Cool, I love the way you've done a separate freestyle example first for this and then integrated. I had a little play with it and left some inline comments for the moment. Before I look a little more though it would be good to get some info on some things here.

I noticed lots of references to qp, QP, QueryParam, queryParam. If I was working on this, I feel that I would be often asking myself 'is this variable/method using the initials or words, is it capitialized?' Overall, do you need to use this prefix here so much? I know you probably won't ever do this, but what if you decided to store the filters elsewhere for some reason, like in localStorage, or just not store them at all?
What was the decision to use facet instead of filter based on? I think this kind of thing is generally called a filter, so 'Filter this list based on datacenter and status for me'. I keep thinking 'what's a facet?' whilst I'm reading this. I'm also looking at the templates and thinking maybe just using:

options=types
selection=currentType
...
options=statuses
selection=currentStatus

or maybe

options=type.options
selection=type.current
...
options=status.options
selection=status.current

Would be good to see what you think here, and try to understand more where you are coming from regarding all of the above?

Other things I noticed:

I initially thought the prefix filtering was broken as it was only showing my one prefix out of a couple in the table. It was only when I looked at the code I saw you only put them in the prefix filter select if there is more that one instance of that prefix. Do you think a user of this may wonder if something is broken?
For the prefix idea itself, what about people using : or something else? Is the _-. thing a common nomad semi-standard?

Anyway, come back to me when you can, I've not approved as yet as I'd like to understand the queries above first. I'm guessing there no immediate rush with this, but let me know if so. Feel free to shout me offline if thats easier.

Thanks,

John

johncowen · 2019-01-25T16:10:22Z

ui/app/controllers/jobs/index.js

+    return [];
+  }
+};
+


Hehe I see what you mean here by unattractive! So my URL right now has:

?status=%5B"pending"%2C"running"%2C"dead"%5D

Generally I've seen these things done with status[]=thing, I'm not sure how ember treats that though, I did notice something the other day related to this, I'll try and dig it out again in a bit incase it helps.

I'm not entirely sure that " should be in URLs, and also that , shouldn't - probably worth having a look to see what is 'usual' here. Do you need the "'s? Are you expecting to have true and "true" at the same time?

Anyway, if you take a look lemme know what you find out.

Here's the thing I was looking at the other day which is ever so slightly related to this

https://github.com/tildeio/route-recognizer/blob/0940966757104ea5297717102b1ae3dc260ee8ee/lib/route-recognizer.ts#L564-L574

Looks like ember is aware of the key[]=value thing, just be careful as I'm not sure it encodes keys properly when you do that. I don't think that would effect you here anyway.

I was honestly expecting Ember to use the status[]=&status[]= style when I bound an array to a query param, but that's not what happened. Instead it basically does what I'm doing now: JSON stringifying.

As for encoding characters, it's curious that you are seeing " and , in the URL, what browser are you using? In Chrome, they were automatically encoded. Not sure if that's a property of Ember or Chrome.

Do you need the "'s? Are you expecting to have true and "true" at the same time?

Yes-ish. Ideally I would change qpSerialize to just arr.join(','), but commas (and basically everything) is a legal job name and datacenter character. So there are other possible encoding schemes than JSON.stringify, but it's not worth spinning my wheels on that.

As for encoding characters, it's curious that you are seeing " and , in the URL

Oh weird were you not getting "s? I was in Chrome. I did find it strange that it seemed to be encoding one but not the other. I'm gonna check this branch out again in a bit and double check. It was definitely showing me actual "s when I did this first pass.

but commas (and basically everything) is a legal job name and datacenter character

Yeah for sure, this is why I was thinking a filter[status][]=url%20encoded%2Cjob-name&filter[status][]=another%22url%20encoded%2Cjob-name seemed to make more sense to me? I'm not entirely sure what ember does though, so I'm not sure how easily it is to make ember produce/consume that - I might have a bit more of a dig in a bit myself later.

Instead it basically does what I'm doing now: JSON stringifying.

So my question would be, what's the reason for doing it here if ember does the same? I don't have enough practical info on what ember does here though.

I think I'd still be tempted to use URL encoding to encode strings for the URL - but there's also an argument to say 'use the framework', and if it uses a javascript encoder to encode the entire data blob into a single string parameter and then URL encode it then maybe there is a reason for that I'm not aware of/haven't thought of. It might just be 'because it's more straightforward'

Definitely getting "s in Chrome

johncowen · 2019-01-25T16:14:55Z

ui/app/controllers/jobs/index.js

+        hist[prefix] = hist[prefix] ? hist[prefix] + 1 : 1;
+      }
+      return hist;
+    }, {});


I'm rubbish at RegEx so not sure on this one, but is there a way to test and match the prefix in one shot?

Yes. The regex could be changed to capture up to the delimiter and also require characters after the delimiter. Then if there's no match or the capture group is empty, that'd mean there was no prefix.

I'm not sure how large of an impact that would make on performance here, but I suppose it's worth investigating.

Up to you. It wasn't really the performance angle that I was coming from (maybe it's more performant to use a test to potentially avoid a match), I don't think performance is important here.

I think it was more of a 'tool for the job' thing.

Actually, if anything from a performance angle, I'd hoist your regex definitions to the top scope maybe? I don't think it matters here though really, I don't think this will ever be that hot, but I could be wrong, don't have enough context there.

johncowen · 2019-01-25T16:20:28Z

ui/app/controllers/jobs/index.js

+
+        return true;
+      });
+    }


For me, I'd consider using some curly brackets instead of one line conditionals here, especially at the end here it gets a little "hold on, what's happening here". I never use this type of one line conditionals though so maybe its just me.

Yeah, it's definitely dense, but a bunch of curlies seems noisy. I had to try really hard to avoid overengineering this 😄 I'll poke at it some more.

Cool, this is more verbose but to my eyes its easier to read so thanks for that! I realized after my comment that your original code might have been more readable originally but maybe prettier wrapped it to make it 'prettier'? 🤷‍♂️

I think this is more just a readability/syntax/style thing rather than an engineering thing, you could maybe do the engineering differently, but I don't think it matters too much here (see below)

Just a last note here if it helps, I use a switch approach with things like this quite a lot, means you get the benefit of one-liners but readability is maintained, again maybe just a 'to my eyes' thing:

switch(true) { case types.length && !types.includes(job.get('displayType')): case statuses.length && !statuses.includes(job.get('status')): case datacenters.length && !job.get('datacenters').find(dc => datacenters.includes(dc)): case prefixes.length && !prefixes.find(prefix => job.get('name').startsWith(prefix)) return false; default: return true; }

Comments can fit in really nicely between the case statements there also if you ever need to get more wordy with what's happening. I generally put the most likely thing to happen at the top.

Little engineering offshoot, but why all the .length checks? Is that to ensure things aren't null/undefined. includes and find will return a falsey value on zero length arrays if I'm not mistaken?

nanoz · 2019-01-31T09:35:50Z

Hi @DingoEatingFuzz !

Are you planning to add the Unsynced status, as found in the Services view of the Hashi UI ? This status is very helpful to us to detect production problems.

DingoEatingFuzz · 2019-01-31T21:48:34Z

Hello @nanoz, the In Sync/Unsynced status in Hashi UI relates to consul service health, right?

The plan is to do a full consul integration, which will include health checks in the job row as well as an additional facet in this filtering view so you can filter jobs by their consul health.

nanoz · 2019-02-01T15:32:21Z

To me, this status is not Consul related. It shows there are differences between what we expect (the job definition) and what actually is (the current state of the job).

DingoEatingFuzz · 2019-02-01T21:19:39Z

Okay, I reread through the hashi-ui code and I think I figured it out this time. A job is "in sync" when its both a service and all its expected allocations are running.

If this is the case, it seems like the underlying use case here is to find jobs that are "stuck"? Jobs that have allocations that are perpetually queued for one reason or another.

If this is the case, there is no current plan to build this, but I am interested in the use case. Simply basing synchronicity on running allocations isn't a complete solution due to deployments, especially with canaries, but potentially down the road we could better query something like "jobs with allocations that have been queued for longer than X time".

DingoEatingFuzz · 2019-02-01T21:46:47Z

Hi @johncowen finally getting around to addressing your questions.

I noticed lots of references to qp, QP, QueryParam, queryParam. If I was working on this, I feel that I would be often asking myself 'is this variable/method using the initials or words, is it capitialized?'

I took inventory of all the places I use qp/QP/queryParam

qpSerialize
qpDeserialize
selectionFromQP
qp[FacetName]
setFacetQueryParam

So, definitely a variety of naming schemes. I think that can be tidied up.

Overall, do you need to use this prefix here so much? I know you probably won't ever do this, but what if you decided to store the filters elsewhere for some reason, like in localStorage, or just not store them at all?

If I wasn't using query params, I'd likely do a lot of this code differently. All of the qp[FacetName] variables would go away, since they are only there to satisfy ember's query param binding and use string values. qpSerialize and qpDeserialize would also go away. They are already kind of temporary, but the idea of special-cased pretty serialization is unique to query params. Nowhere else do people care or see the stored format of data. selectionFromQP Isn't necessarily query param related, but since it's a specific computed property macro related to the qp[FacetName] step, I think it's good to have query param mentioned in it. setFacetQueryParam doesn't have to include query param, since that detail isn't necessary in the template. I don't think it hurts either, but now I'm swaying towards changing it.

What was the decision to use facet instead of filter based on? I think this kind of thing is generally called a filter, so 'Filter this list based on datacenter and status for me'. I keep thinking 'what's a facet?'

This type of search is called faceted search. These are also filters, but lots of things are filters. IMO, facet is a more descriptive name.

whilst I'm reading this. I'm also looking at the templates and thinking maybe just using:

I like that first option. My concern that led to long names is that there is a lot going on in the controller, so it might be clearer if I gave the selections and options specific names. Maybe that's not necessary. The second option looks nice and grouping like-properties in objects is of course good, but it makes specifying dependent keys and setting properties harder.

I initially thought the prefix filtering was broken as it was only showing my one prefix out of a couple in the table. It was only when I looked at the code I saw you only put them in the prefix filter select if there is more that one instance of that prefix. Do you think a user of this may wonder if something is broken?

Maybe? It's definitely an experiment that may fall short, but if the goal here is to help people filter jobs, I don't want to introduce the problem of having to weed through all the prefixes. I don't think a prefix used on one job is worth filtering by. Maybe I'm wrong thinking that.

For the prefix idea itself, what about people using : or something else? Is the _-. thing a common nomad semi-standard?

I just chose them because they are common semi-standards across all naming conventions. : or other things might be used. It's also possible that a useful prefix is actually something like consul-staging- rather than consul-. Hopefully if this doesn't work for people, they will file issues.

johncowen

Hey 👋

Thanks for revisiting this! I've had a quick look over your inlines and added some more thoughts. I'm going to try check this back out and have another deeper look now and come back later.

This type of search is called faceted search. These are also filters, but lots of things are filters. IMO, facet is a more descriptive name.

Oh cool, never heard that, I looked it up also:

https://en.wikipedia.org/wiki/Faceted_search

It does sound like this fits with what you are doing here so fair enough, I'd still wonder how many people would recognise setFacetQueryParam over setFilterQueryParam, but again possibly just a me thing so don't worry.

Hopefully if this doesn't work for people, they will file issues.

Cool, sounds good - I like the MVP and then iterate thing. Do you folks ever do any sort of pre-release user testing? We've got some really good detailed info from users that might help with things like this?

Hopefully come back with some more thought here or a LGTM before you are about today

Cheers,

John

johncowen · 2019-02-05T11:58:33Z

ui/app/controllers/jobs/index.js

+    return [];
+  }
+};
+


As for encoding characters, it's curious that you are seeing " and , in the URL

Oh weird were you not getting "s? I was in Chrome. I did find it strange that it seemed to be encoding one but not the other. I'm gonna check this branch out again in a bit and double check. It was definitely showing me actual "s when I did this first pass.

but commas (and basically everything) is a legal job name and datacenter character

Yeah for sure, this is why I was thinking a filter[status][]=url%20encoded%2Cjob-name&filter[status][]=another%22url%20encoded%2Cjob-name seemed to make more sense to me? I'm not entirely sure what ember does though, so I'm not sure how easily it is to make ember produce/consume that - I might have a bit more of a dig in a bit myself later.

Instead it basically does what I'm doing now: JSON stringifying.

So my question would be, what's the reason for doing it here if ember does the same? I don't have enough practical info on what ember does here though.

I think I'd still be tempted to use URL encoding to encode strings for the URL - but there's also an argument to say 'use the framework', and if it uses a javascript encoder to encode the entire data blob into a single string parameter and then URL encode it then maybe there is a reason for that I'm not aware of/haven't thought of. It might just be 'because it's more straightforward'

johncowen · 2019-02-05T12:03:07Z

ui/app/controllers/jobs/index.js

+        hist[prefix] = hist[prefix] ? hist[prefix] + 1 : 1;
+      }
+      return hist;
+    }, {});


Up to you. It wasn't really the performance angle that I was coming from (maybe it's more performant to use a test to potentially avoid a match), I don't think performance is important here.

I think it was more of a 'tool for the job' thing.

Actually, if anything from a performance angle, I'd hoist your regex definitions to the top scope maybe? I don't think it matters here though really, I don't think this will ever be that hot, but I could be wrong, don't have enough context there.

johncowen · 2019-02-05T12:13:46Z

ui/app/controllers/jobs/index.js

+
+        return true;
+      });
+    }


Cool, this is more verbose but to my eyes its easier to read so thanks for that! I realized after my comment that your original code might have been more readable originally but maybe prettier wrapped it to make it 'prettier'? 🤷‍♂️

I think this is more just a readability/syntax/style thing rather than an engineering thing, you could maybe do the engineering differently, but I don't think it matters too much here (see below)

Just a last note here if it helps, I use a switch approach with things like this quite a lot, means you get the benefit of one-liners but readability is maintained, again maybe just a 'to my eyes' thing:

switch(true) { case types.length && !types.includes(job.get('displayType')): case statuses.length && !statuses.includes(job.get('status')): case datacenters.length && !job.get('datacenters').find(dc => datacenters.includes(dc)): case prefixes.length && !prefixes.find(prefix => job.get('name').startsWith(prefix)) return false; default: return true; }

Comments can fit in really nicely between the case statements there also if you ever need to get more wordy with what's happening. I generally put the most likely thing to happen at the top.

Little engineering offshoot, but why all the .length checks? Is that to ensure things aren't null/undefined. includes and find will return a falsey value on zero length arrays if I'm not mistaken?

johncowen

Hey,

I've had another play with this in place and I have a few non-important right now comments re: usability more than anything, plus I added a couple more things I included inline.

I think overall some of it doesn't feel like your usual tidy style (mainly re the comment inline on moving some vars to the top of your class definition). So maybe take another pass at that? Maybe you have a reason for doing it different here?

I had a few other things that aren't hugely important right in the scheme of things, and I want to make sure things can keep moving on this, so I'm going to approve as everything works/tests pass etc. Just I think there are refinements that could optionally be made at some point, but you may get to some of these or plan some of these before you finally merge all this into master. I'll list some of these here just FYI but I'm not suggesting these absolutely need to be done.

There is a lot of UI 'jumping around'. Clicking on things in the filter makes widths of the table change, widths of the filter buttons change, even the URL does this strange changing thing (it seems to swap the order of the query params after a second or so). All this jumping around can get a bit finickity for example you can click on a filter under your mouse to tick a checkbox and the menu moves out from under you mouse so you can't immediately click again to untick the checkbox, you have to move your mouse again and then click.
How useful are the numbers that appear in your filter buttons? How useful is it to know that I've filtered by 3 or 4 filters? Or do I just need to know that it contains an enabled filter? It's a funny one this as we've been discussing this in a semi-related thing we have over in consul land. Would a count/total of jobs with that type be a more useful number here? This might be especially useful in a paged UI as it would make it easier to know at a glance maybe if you had any 'dead' jobs, and how many.
I know you did a great job on the mobile menu and you put a lot of effort into make the UI accessible. I did a quick squeeze of this to check what the mobile view was like. Are there any plans for responsive layouts here for people wanting to do a quick check for say 'dead' jobs with a quick glance on a mobile?
I'm guessing you will want to reuse a lot of this code for other models/areas (so allocations etc). I can think of a few things here that could make this difficult, so I'm interested to see what your plans are/the outcome is for doing this.

Lastly a little question for me for the future. What's the easiest way to turn off all the mirage console.logging whilst looking at this. I was scattering some console.logs about myself whilst looking at this and the mirage logging makes it difficult to see any other logs that I'm adding.

Anyway ping me if you want to talk further about any of this.

johncowen · 2019-02-05T18:46:25Z

ui/app/controllers/jobs/index.js

+  selectionStatus: qpSelection('qpStatus'),
+  selectionDatacenter: qpSelection('qpDatacenter'),
+  selectionPrefix: qpSelection('qpPrefix'),
+


Should all these go up at the top of the class definition with your other variables?

johncowen · 2019-02-05T18:47:18Z

ui/app/controllers/jobs/index.js

  /**
    Filtered jobs are those that match the selected namespace and aren't children
    of periodic or parameterized jobs.
  */
-  filteredJobs: computed('model.[]', 'model.@each.parent', function() {
+  visibleJobs: computed('model.[]', 'model.@each.parent', function() {


If you are changing the name of the property here, maybe change the comment also? Or maybe the comment refers to the code under this computedProperty now? Not sure

johncowen · 2019-02-05T18:50:31Z

ui/app/controllers/jobs/index.js

+    scheduleOnce('actions', () => {
+      this.set(
+        'qpDatacenter',
+        qpSerialize(intersection(availableDatacenters, this.get('selectionDatacenter')))


Can you use a.filter(item => b.includes(item)) here? Will save you a dependency? Not sure if I've read this right?

That'd work fine, but it wouldn't save me a dependency since I'm already using intersection elsewhere.

Ah cool, I think it's just here:

nomad/ui/app/models/allocation.js

Line 73 in c12bdcd

return intersection(taskGroupUnhealthyDrivers, nodeUnhealthyDrivers);

You could remove lodash there also? I suppose it depends what side of the fence you are on, but it would save a dependency, no biggie either way.

DingoEatingFuzz · 2019-02-11T23:47:21Z

Thanks for the review John, this is definitely still a WIP regarding the big picture of faceted search. As for your four points, here are my responses.

I hear you on the jumping, but I think it's acceptable. The table widths are a bigger problem than this project that maybe will be addressed some day with fixed widths. The URL jumping I didn't observe, the facet width jumping is unfortunate but seems fine to me since the entire option is clickable. The jumping I'm least happy with is the jumping that occurs when the search box disappears (when there are no matching items). I'm still okay with it since it's a rarer occurrence.
The most important thing is to know that the facet is "active". Having the counts would be nice, especially within the list, but I didn't want to do all that counting client-side.
Yes, there are plans to make this mobile friendly. I should add that to the parent PR checklist.
I honestly don't see a lot of code sharing happening here. The multi-select component will of course be shared, and some of the helpers might be shared, but I don't want to bend over backwards drying out this code. For the foreseeable future, this pattern will only be in two places: jobs and clients. Since there are only two places, I think there is a very good chance that over abstracting things to avoid repeating code will make a bigger mess of things than some duplication. It's something I'll think more about in the clients faceted search PR.

johncowen · 2019-02-12T09:58:37Z

🙏 thanks for giving me your reasoning here, I think a lot of it makes sense.

Onwards and upwards!

Fuco1 · 2019-09-29T11:43:09Z

Changelog says this was released on 0.9.2, I run 0.9.5 but don't see these features. Do I need some special flag to enable it?

DingoEatingFuzz · 2019-09-30T16:21:56Z

@Fuco1, there is no special flag. I just tested with 0.9.2 and see the filters as long as a job is running.

My only suggestions are to clear your local cache, and verify that the server nodes are in fact running 0.9.5.

Wish I had a better response for you 🙁

Fuco1 · 2019-09-30T18:51:20Z

The servers are running 0.9.5 according to the server tab

I cleared the local storage in my browser and did a hard-reload and a browser restart.

> nomad node  status -verbose | grep server
ID                                    DC   Name               Class   Address     Version  Drain  Eligibility  Status
1d5244e2-f922-0d38-20bf-3a59a566cf3a  dc1  nomad-server-0     <none>  10.0.0.7    0.9.5    false  eligible     ready
4b976e41-02ba-0c68-55ba-401577c1350f  dc1  nomad-server-1     <none>  10.0.0.8    0.9.5    false  eligible     ready
8140f868-aebc-d96b-be87-4f532563f426  dc1  nomad-server-2     <none>  10.0.0.10   0.9.5    false  eligible     ready

github-actions · 2023-01-30T02:14:44Z

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

DingoEatingFuzz added 7 commits January 23, 2019 20:36

Scaffold the facets and facet options for the jobs list page

8ed8a85

Implement the dynamic facet lists (datacenters and prefixes)

3d87c47

Implement the job list filtering based on facet selection

3b235a1

Support for the no options case

5aef4d9

Introduce encode/decode for array query params

3b8187f

Model facets in the page object

b20dc67

Test coverage for job list facets

0d8dd50

DingoEatingFuzz added the theme/ui label Jan 24, 2019

DingoEatingFuzz requested a review from a team January 24, 2019 19:07

DingoEatingFuzz mentioned this pull request Jan 24, 2019

UI: Faceted Search #5235

Merged

4 tasks

johncowen reviewed Jan 25, 2019

View reviewed changes

DingoEatingFuzz added 2 commits February 1, 2019 14:08

Simplify options and selection names

a207fdd

Make the facet filter function clearer with more brackets

2fdec7e

johncowen reviewed Feb 5, 2019

View reviewed changes

johncowen approved these changes Feb 5, 2019

View reviewed changes

Changes from code review

b769365

DingoEatingFuzz merged commit 83d9190 into f-ui-faceted-search Feb 11, 2019

DingoEatingFuzz deleted the f-ui-jobs-filtering branch February 11, 2019 23:58

github-actions bot locked as resolved and limited conversation to collaborators Jan 30, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

UI: Faceted search on the jobs list page #5236

UI: Faceted search on the jobs list page #5236

DingoEatingFuzz commented Jan 24, 2019

johncowen left a comment •

edited

Loading

johncowen Jan 25, 2019

johncowen Jan 25, 2019

DingoEatingFuzz Feb 1, 2019

johncowen Feb 5, 2019

johncowen Feb 5, 2019

johncowen Jan 25, 2019

DingoEatingFuzz Feb 1, 2019

johncowen Feb 5, 2019 •

edited

Loading

johncowen Jan 25, 2019

DingoEatingFuzz Feb 1, 2019

johncowen Feb 5, 2019 •

edited

Loading

nanoz commented Jan 31, 2019

DingoEatingFuzz commented Jan 31, 2019

nanoz commented Feb 1, 2019 •

edited

Loading

DingoEatingFuzz commented Feb 1, 2019

DingoEatingFuzz commented Feb 1, 2019

johncowen left a comment •

edited

Loading

johncowen Feb 5, 2019

johncowen Feb 5, 2019 •

edited

Loading

johncowen Feb 5, 2019 •

edited

Loading

johncowen left a comment

johncowen Feb 5, 2019

johncowen Feb 5, 2019

johncowen Feb 5, 2019

DingoEatingFuzz Feb 11, 2019

johncowen Feb 12, 2019

DingoEatingFuzz commented Feb 11, 2019

johncowen commented Feb 12, 2019

Fuco1 commented Sep 29, 2019

DingoEatingFuzz commented Sep 30, 2019

Fuco1 commented Sep 30, 2019

github-actions bot commented Jan 30, 2023

UI: Faceted search on the jobs list page #5236

UI: Faceted search on the jobs list page #5236

Conversation

DingoEatingFuzz commented Jan 24, 2019

johncowen left a comment • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

johncowen Feb 5, 2019 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

johncowen Feb 5, 2019 • edited Loading

Choose a reason for hiding this comment

nanoz commented Jan 31, 2019

DingoEatingFuzz commented Jan 31, 2019

nanoz commented Feb 1, 2019 • edited Loading

DingoEatingFuzz commented Feb 1, 2019

DingoEatingFuzz commented Feb 1, 2019

johncowen left a comment • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

johncowen Feb 5, 2019 • edited Loading

Choose a reason for hiding this comment

johncowen Feb 5, 2019 • edited Loading

Choose a reason for hiding this comment

johncowen left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

DingoEatingFuzz commented Feb 11, 2019

johncowen commented Feb 12, 2019

Fuco1 commented Sep 29, 2019

DingoEatingFuzz commented Sep 30, 2019

Fuco1 commented Sep 30, 2019

github-actions bot commented Jan 30, 2023

johncowen left a comment •

edited

Loading

johncowen Feb 5, 2019 •

edited

Loading

johncowen Feb 5, 2019 •

edited

Loading

nanoz commented Feb 1, 2019 •

edited

Loading

johncowen left a comment •

edited

Loading

johncowen Feb 5, 2019 •

edited

Loading

johncowen Feb 5, 2019 •

edited

Loading