Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[question] Rolling Deploys and -1 vs +1 on scale #5440

Closed
giuseppe7 opened this issue Mar 19, 2019 · 3 comments
Closed

[question] Rolling Deploys and -1 vs +1 on scale #5440

giuseppe7 opened this issue Mar 19, 2019 · 3 comments

Comments

@giuseppe7
Copy link

My apologies if this is not the preferred location for question. Could you provide the reasoning as to why the rolling deploys would diminish capacity by N instead of increase capacity by N? If I were to run a small cluster of foo with 5 instances, doing the rolling deploy with max_parallel of 1 would still leave me diminished by 20% at first, where both tear down (which is quick) happens before start up (which is slow) occurs. Wouldn't it be safer to start with 5 + 1new?

@pznamensky
Copy link

It leads to another problem in cases when you're deploying tasks which can't start because of failed code in container or similar. In this case, after several deploys, it would be no running instances at all.
I'm voting for increasing capacity at deploy.

@notnoop
Copy link
Contributor

notnoop commented Mar 22, 2019

Good question. Rolling deploys is currently designed to roll out services without requiring additional cluster capacity.

We recommend using canaries when upgrading new code to be inspected, and canaries use surge capacity in addition to the main, and when promoting them, you should have the expected number of services running at all times, and we intend to improve that flow with automatic canary promotion as part of #3636. This approach should give your desired behavior.

@notnoop notnoop closed this as completed Mar 22, 2019
@github-actions
Copy link

I'm going to lock this issue because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants