Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add denormalized Eval.DequeueID RPC #5452

Open
schmichael opened this issue Mar 20, 2019 · 0 comments
Open

Add denormalized Eval.DequeueID RPC #5452

schmichael opened this issue Mar 20, 2019 · 0 comments

Comments

@schmichael
Copy link
Member

#5407 made me realize that thanks to #5381 there's no reason to serialize the whole Evaluation over the Dequeue RPC because the worker will wait until the Eval is available locally before processing it. #5411 makes retrieving the Eval from the state store even easier.

Proposal

A new RPC could be added - DequeueID - that replaces the *structs.Evaluation in the response with just an EvalID string. Workers would then retrieve the Eval by EvalID after waiting on the WaitIndex.

Performance

struct.Evaluation is small, so unless ClassEligibility or FailedTGAllocs are large, the performance impact may be negligible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant