vault: fix renewal time #5479
Merged
vault: fix renewal time #5479
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM! |
schmichael
force-pushed
the
b-vault-renewal
branch
from
516def8
to
48dc7c0
Compare
schmichael
added a commit
that referenced
this pull request
Apr 11, 2019
preetapan
approved these changes
Apr 11, 2019
schmichael
force-pushed
the
b-vault-renewal
branch
from
90e3f3c
to
821e0a4
Compare
schmichael
added a commit
that referenced
this pull request
Apr 11, 2019
Renewal time was being calculated as 10s+Intn(lease-10s), so the renewal time could be very rapid or within 1s of the deadline: [10s, lease) This commit fixes the renewal time by calculating it as: (lease/2) +/- 10s For a lease of 60s this means the renewal will occur in [20s, 40s).
schmichael
force-pushed
the
b-vault-renewal
branch
from
821e0a4
to
888304b
Compare
|
@schmichael is this also a bug in the 0.8.x line? |
|
@jippi Yes, unfortunately this bug goes wwwwwway back. |
|
@schmichael any chance to backport to 0.8? we've been suffering quite a lot from Nomad<>Vault nomad-servers & allocs losing their credentials to DBs and similar, and this seem like a pretty good bet on that issue. I would estimate our issues has caused 4-7h of total downtime in prod last 2 years |
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Renewal time was being calculated as 10s+Intn(lease-10s), so the renewal
time could be very rapid or within 1s of the deadline: [10s, lease)
This commit fixes the renewal time by calculating it as:
For a lease of 60s this means the renewal will occur in [20s, 40s).
Fixes #5471