Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] - add namespace label to nomad.client.allocs.* #5554

Closed
henrikjohansen opened this issue Apr 12, 2019 · 5 comments · Fixed by #5847
Closed

[feature] - add namespace label to nomad.client.allocs.* #5554

henrikjohansen opened this issue Apr 12, 2019 · 5 comments · Fixed by #5847

Comments

@henrikjohansen
Copy link

henrikjohansen commented Apr 12, 2019

Using namespaces it's suddenly possible to have multiple jobs with the same jobname running.

In our case, the Telemetry data is made available to service owners & developers but without some unique identifier we can no longer route those events correctly :(

I would like to propose adding the namespace as an additional label to all nomad.client.allocs.* metrics in order to make ☝️ possible.

Example : nomad.client.allocs.<Namespace>.<Job>.<TaskGroup>.<AllocID>.<Task>.metric

@cgbaker
Copy link
Contributor

cgbaker commented Apr 12, 2019

Agreed. I'll take this to the team, this should be pretty easy to get in.

@henrikjohansen
Copy link
Author

@cgbaker Any updates on this?

@cgbaker
Copy link
Contributor

cgbaker commented May 13, 2019

@henrikjohansen , we didn't get it in for the upcoming 0.9.2, but we have put it on the list for 0.9.3. apologies for the delay on this.

@cgbaker
Copy link
Contributor

cgbaker commented Jun 18, 2019

@henrikjohansen , merged, will be part of upcoming 0.9.4. thank you for your patience.

@github-actions
Copy link

I'm going to lock this issue because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants