Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[question] New release? #5733

Closed
mattolson opened this issue May 20, 2019 · 5 comments
Closed

[question] New release? #5733

mattolson opened this issue May 20, 2019 · 5 comments

Comments

@mattolson
Copy link

mattolson commented May 20, 2019

We are very keen to roll out spread, but were waiting on the fix in #5713. Any chance we can get a release published with this fix? We'd much rather use an official release than roll our own.

🙏

@cgbaker
Copy link
Contributor

cgbaker commented May 21, 2019

We are finalizing 0.9.2 right now. It will include this fix.

@cgbaker cgbaker closed this as completed May 21, 2019
@rsigrest
Copy link

I built a test release of the current master branch and deployed it - I believe everything in the scheduler is working as expected but I've encountered a bug in the UI. Seems like it's trying to index into a null array, though the XHR requests to /v1/jobs is returning populated arrays . I get this from firefox:

TypeError: t.match(...) is null[Learn More] nomad-ui-3862716e00185c2061ad87166e17726a.js:425:336
    a https://nomad.example.com/ui/assets/nomad-ui-3862716e00185c2061ad87166e17726a.js:425
    reduce self-hosted:359
    optionsPrefix https://nomad.example.com/ui/assets/nomad-ui-3862716e00185c2061ad87166e17726a.js:425
    get https://nomad.example.com/ui/assets/vendor-121fbe0a713949ae14198625db799c6f.js:3379
    ne https://nomad.example.com/ui/assets/vendor-121fbe0a713949ae14198625db799c6f.js:3296
    compute https://nomad.example.com/ui/assets/vendor-121fbe0a713949ae14198625db799c6f.js:2825
    value https://nomad.example.com/ui/assets/vendor-121fbe0a713949ae14198625db799c6f.js:2821
    value https://nomad.example.com/ui/assets/vendor-121fbe0a713949ae14198625db799c6f.js:2492
    bt https://nomad.example.com/ui/assets/vendor-121fbe0a713949ae14198625db799c6f.js:2961
    create https://nomad.example.com/ui/assets/vendor-121fbe0a713949ae14198625db799c6f.js:2974
    <anonymous> https://nomad.example.com/ui/assets/vendor-121fbe0a713949ae14198625db799c6f.js:2259
    evaluate https://nomad.example.com/ui/assets/vendor-121fbe0a713949ae14198625db799c6f.js:2136
    evaluateSyscall https://nomad.example.com/ui/assets/vendor-121fbe0a713949ae14198625db799c6f.js:2395
    evaluateInner https://nomad.example.com/ui/assets/vendor-121fbe0a713949ae14198625db799c6f.js:2387
    evaluateOuter https://nomad.example.com/ui/assets/vendor-121fbe0a713949ae14198625db799c6f.js:2387
    next https://nomad.example.com/ui/assets/vendor-121fbe0a713949ae14198625db799c6f.js:2513
    execute https://nomad.example.com/ui/assets/vendor-121fbe0a713949ae14198625db799c6f.js:2512
    handleException https://nomad.example.com/ui/assets/vendor-121fbe0a713949ae14198625db799c6f.js:2453
    handleException https://nomad.example.com/ui/assets/vendor-121fbe0a713949ae14198625db799c6f.js:2465
    throw https://nomad.example.com/ui/assets/vendor-121fbe0a713949ae14198625db799c6f.js:2448
    evaluate https://nomad.example.com/ui/assets/vendor-121fbe0a713949ae14198625db799c6f.js:2200
    execute https://nomad.example.com/ui/assets/vendor-121fbe0a713949ae14198625db799c6f.js:2448
    rerender https://nomad.example.com/ui/assets/vendor-121fbe0a713949ae14198625db799c6f.js:2466
    render https://nomad.example.com/ui/assets/vendor-121fbe0a713949ae14198625db799c6f.js:3004
    C https://nomad.example.com/ui/assets/vendor-121fbe0a713949ae14198625db799c6f.js:3257
    _renderRoots https://nomad.example.com/ui/assets/vendor-121fbe0a713949ae14198625db799c6f.js:3025
    _renderRootsTransaction https://nomad.example.com/ui/assets/vendor-121fbe0a713949ae14198625db799c6f.js:3030
    _revalidate https://nomad.example.com/ui/assets/vendor-121fbe0a713949ae14198625db799c6f.js:3032
    invoke https://nomad.example.com/ui/assets/vendor-121fbe0a713949ae14198625db799c6f.js:2607
    flush https://nomad.example.com/ui/assets/vendor-121fbe0a713949ae14198625db799c6f.js:2600
    flush https://nomad.example.com/ui/assets/vendor-121fbe0a713949ae14198625db799c6f.js:2611
    _end https://nomad.example.com/ui/assets/vendor-121fbe0a713949ae14198625db799c6f.js:2658
    end https://nomad.example.com/ui/assets/vendor-121fbe0a713949ae14198625db799c6f.js:2624
    _run https://nomad.example.com/ui/assets/vendor-121fbe0a713949ae14198625db799c6f.js:2659
    _join https://nomad.example.com/ui/assets/vendor-121fbe0a713949ae14198625db799c6f.js:2658
    join https://nomad.example.com/ui/assets/vendor-121fbe0a713949ae14198625db799c6f.js:2635
    h https://nomad.example.com/ui/assets/vendor-121fbe0a713949ae14198625db799c6f.js:1817
    success https://nomad.example.com/ui/assets/vendor-121fbe0a713949ae14198625db799c6f.js:7409
    u https://nomad.example.com/ui/assets/vendor-121fbe0a713949ae14198625db799c6f.js:1283
    fireWith https://nomad.example.com/ui/assets/vendor-121fbe0a713949ae14198625db799c6f.js:1284
    O https://nomad.example.com/ui/assets/vendor-121fbe0a713949ae14198625db799c6f.js:1556
    n https://nomad.example.com/ui/assets/vendor-121fbe0a713949ae14198625db799c6f.js:1566

and this from chrome:

Uncaught TypeError: Cannot read property '1' of null
    at nomad-ui-3862716e00185c2061ad87166e17726a.js:425
    at Array.reduce (<anonymous>)
    at n.<anonymous> (nomad-ui-3862716e00185c2061ad87166e17726a.js:425)
    at n.get (vendor-121fbe0a713949ae14198625db799c6f.js:3379)
    at ne (vendor-121fbe0a713949ae14198625db799c6f.js:3296)
    at t.compute (vendor-121fbe0a713949ae14198625db799c6f.js:2825)
    at t.value (vendor-121fbe0a713949ae14198625db799c6f.js:2821)
    at e.value (vendor-121fbe0a713949ae14198625db799c6f.js:2492)
    at bt (vendor-121fbe0a713949ae14198625db799c6f.js:2961)
    at r.create (vendor-121fbe0a713949ae14198625db799c6f.js:2974)

Results in a blank screen at /ui/jobs. To build this release, I used make prerelease followed by make release in the vagrant VM. I had to do a bit of work to get everything actually working in that VM so it's totally possible I messed something up, just wanted to call this out just in case.

@cgbaker
Copy link
Contributor

cgbaker commented May 21, 2019

@rsigrest , please file this in a separate issue

@rsigrest
Copy link

@cgbaker - thanks, created #5745

@github-actions
Copy link

I'm going to lock this issue because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants