Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lift code from docker/volume/mounts for splitting windows volumes #5811

Merged
merged 4 commits into from
Jun 19, 2019

Conversation

damoxc
Copy link
Contributor

@damoxc damoxc commented Jun 11, 2019

Using the API as provided from the mounts package imposes validation
on the src:dest which shouldn't be performed at this time. To workaround
that lift the internal code from that library required to only perform
the split.

Just wanted to share the patch I've used to fix Nomad for our use case, I'm not sure if this is the road you will want to down though.

A proposed fix for #5798.

@hashicorp-cla
Copy link

hashicorp-cla commented Jun 11, 2019

CLA assistant check
All committers have signed the CLA.

@notnoop
Copy link
Contributor

notnoop commented Jun 11, 2019

Thanks @damoxc, this seems promising indeed ! I would suggest moving lifted code to a separate file and include a comment linking to original source along with license notice.

@damoxc
Copy link
Contributor Author

damoxc commented Jun 11, 2019

@notnoop My pleasure! I've moved the code out to a new file and added some comments to the top to the source file and license in the Docker repository, is that what you were after?

Using the API as provided from the `mounts` package imposes validation
on the `src:dest` which shouldn't be performed at this time. To workaround
that lift the internal code from that library required to only perform
the split.
@notnoop notnoop merged commit 858e98c into hashicorp:master Jun 19, 2019
@notnoop
Copy link
Contributor

notnoop commented Jun 19, 2019

Thank you so much for your contribution! I'll follow up and update appveyor tests (which sadly don't run on PR builds).

notnoop pushed a commit that referenced this pull request Jun 19, 2019
@github-actions
Copy link

github-actions bot commented Feb 8, 2023

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants