Remove deprecated code

[preetapan]

Removed upgrade path code and tests related to:

• Namespaces (Available since 0.7.0)
• SubmitTime/Version (0.6.0)
• Job Summaries (0.4.0)

[notnoop]

overall look good to me but some questions to understand implication:

• Should "Remove in 0.9" sections be removed right before 0.10 or anytime after 0.9.0? Given that the drain request format changed in 0.8, it'd feel a bit odd dropping support for old format in 0.9.4.
• For the FSM 0.7 compatibility changes - does dropping these means long running nomad servers must at least snapshot once between upgrading from 0.7 to 0.9.4?

[notnoop]

I like the utility function here, as it's not obvious that job.Submit is in nano seconds.

[preetapan]

overall look good to me but some questions to understand implication:

• Should "Remove in 0.9" sections be removed right before 0.10 or anytime after 0.9.0? Given that the drain request format changed in 0.8, it'd feel a bit odd dropping support for old format in 0.9.4.

That's fair, perhaps one major version is too short of a deprecation cycle for node drain. I could roll back these changes. In 0.9.4 we could start emitting a warning when servicing requests that use the old format. .

• For the FSM 0.7 compatibility changes - does dropping these means long running nomad servers must at least snapshot once between upgrading from 0.7 to 0.9.4?

Nomad 0.7 added namespaces and introduced code to fix up older state store objects that were missing namespaces. As long as the servers were making raft transactions it should have corrected old objects that don't have namespace set (not necessarily tied to snapshots)

[notnoop]

Nomad 0.7 added namespaces and introduced code to fix up older state store objects that were missing namespaces

Cool, let me clarify: Would nomad 0.7 edit the raft log old persisted entries in place in file and how do we do that? I was expecting Nomad 0.7 to parse old log entries and populate missing namespace fields in memory, and then storing updated entries to raft snapshot without updating old entries.

[preetapan]

Would nomad 0.7 edit the raft log old persisted entries in place in file and how do we do that? I was expecting Nomad 0.7 to parse old log entries and populate missing namespace fields in memory, and then storing updated entries to raft snapshot without updating old entries.

AFAICT we use the canonicalize method in restore to fix up jobs, but we dont do that consistently for all objects. You are right about your understanding though - The code I removed in various upsert methods would handle processing old log entries - when upserting those entries into the state store Nomad 0.7 would add the namespace field. At that point the statestore in memory would have namespace in it, but not the old log entries on disk. Once we are past the snapshot threshold (8192 entries) we would take a snapshot which saves the statestore (now with namespace in it) to disk, and delete old log entries.

[github-actions]

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.