More restart policy options and consolidate batch/service restart tracker #594
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -110,7 +110,7 @@ func (r *AllocRunner) RestoreState() error { | |||
| r.restored[name] = struct{}{} | |||
|
|
|||
| task := &structs.Task{Name: name} | |||
| restartTracker := newRestartTracker(r.alloc.Job.Type, r.RestartPolicy) | |||
| restartTracker := NewRestartTracker(r.RestartPolicy) | |||
There was a problem hiding this comment.
should client depend on code from the api package?
There was a problem hiding this comment.
This isn't from the api package. It is defined in the client package
dadgar
force-pushed
the
f-restart-policy
branch
from
af5b402
to
5c3e5e7
Compare
| maxAttempts: restartPolicy.Attempts, | ||
| delay: restartPolicy.Delay, | ||
| } | ||
| func NewRestartTracker(policy *structs.RestartPolicy) *RestartTracker { |
There was a problem hiding this comment.
Does this need to be exportable?
There was a problem hiding this comment.
I guess not. I can make it private
dadgar
force-pushed
the
f-restart-policy
branch
from
375af2b
to
95f9339
Compare
dadgar
added a commit
that referenced
this pull request
Dec 18, 2015
More restart policy options and consolidate batch/service restart tracker
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More restart policy options and consolidate batch/service restart tracker