Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

command/agent: allow the job GC interval to be configured #5978

Merged
merged 1 commit into from
Jul 30, 2019
Merged

command/agent: allow the job GC interval to be configured #5978

merged 1 commit into from
Jul 30, 2019

Conversation

pete-woods
Copy link
Contributor

This avoids having to schedule a service to call the GC endpoint more frequently.

@hashicorp-cla
Copy link

hashicorp-cla commented Jul 18, 2019 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@pete-woods pete-woods closed this Jul 18, 2019
@pete-woods pete-woods reopened this Jul 18, 2019
@pete-woods pete-woods force-pushed the configurable-job-gc-interval branch from 2aad6f8 to 30cf468 Compare July 22, 2019 12:10
@pete-woods
Copy link
Contributor Author

pete-woods commented Jul 22, 2019 •
edited
Loading

Hi @notnoop, @cgbaker, @jazzyfresh ! Would any of you folks have a moment to have a look at this (hopefully) straightforward PR?

Sorry for the random @, you all just seemed to be involved in many of the recent PRs, and I can't request reviewers directly it seems. :)

@langmartin langmartin self-requested a review July 22, 2019 18:03
@pete-woods
Copy link
Contributor Author

Thanks @langmartin !

@pete-woods pete-woods changed the title Allow the job GC interval to be configured from default of 5 minutes command/agent: Allow the job GC interval to be configured from default of 5 minutes Jul 24, 2019
@pete-woods pete-woods changed the title command/agent: Allow the job GC interval to be configured from default of 5 minutes command/agent: allow the job GC interval to be configured Jul 24, 2019
@pete-woods
Copy link
Contributor Author

Getting this upstreamed would be very helpful to us here at CircleCI!

langmartin
langmartin approved these changes Jul 25, 2019
View reviewed changes
Copy link
Contributor

@langmartin langmartin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks! this looks good

@langmartin langmartin added this to the 0.10.0 milestone Jul 25, 2019
schmichael
schmichael approved these changes Jul 25, 2019
View reviewed changes
Copy link
Member

@schmichael schmichael left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Going to let this linger until 0.9.4 final is released to avoid any git branching/rebasing/merging hijinx.

website/source/docs/configuration/server.html.md Outdated Show resolved Hide resolved
@pete-woods pete-woods force-pushed the configurable-job-gc-interval branch from 30cf468 to 66bf8eb Compare July 26, 2019 09:11
@schmichael schmichael merged commit c52edb3 into hashicorp:master Jul 30, 2019
@schmichael
Copy link
Member

Thanks again @pete-woods ! You may have had the first merge of 0.10.0. 😄

schmichael added a commit that referenced this pull request Jul 30, 2019
@schmichael
changelog: add #5978
756177c
@pete-woods pete-woods deleted the configurable-job-gc-interval branch July 31, 2019 06:31
@pete-woods
Copy link
Contributor Author

Thanks, everyone. I've got another one (#6003) that adds some new metrics we use for monitoring our nomad clusters here at CircleCI, if any of you have time for more reviews. 🙂

@jazzyfresh jazzyfresh mentioned this pull request Sep 5, 2019
Merged
@github-actions
Copy link

github-actions bot commented Feb 6, 2023

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@schmichael schmichael schmichael approved these changes

@langmartin langmartin langmartin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.10.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@pete-woods @hashicorp-cla @schmichael @langmartin