Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ShutdownDelay should apply on shutdowns and "healthy" restarts #5980

Open
2 tasks
schmichael opened this issue Jul 18, 2019 · 0 comments
Open
2 tasks

ShutdownDelay should apply on shutdowns and "healthy" restarts #5980

schmichael opened this issue Jul 18, 2019 · 0 comments

Comments

@schmichael
Copy link
Member

Background

The documentation for shutdown_delay makes it unclear under which scenarios the delay is applied. The behavior changed in Nomad 0.9.0:

  • 0.8.7 - Delay applies only when stopping a task.
  • 0.9.0 - Delay applies when stopping a task and when restarting a task.

PR #5957 would have tweaked the behavior further:

  • Delay applies when stopping a task and when restarting a "healthy" task. Restarts due to failures - such as check_restart induced restarts - are not delayed.

Unfortunately PR #5975 was accepted over #5957 because it was a more conservative approach to fixing a critical bug (#5395), and the accepted PR lacks the shutdown delay improvement.

Enhancement

  • Shutdown delay should not apply to unhealthy restarts like check_restart.
  • Shutdown delay's documentation should be updated to reflect its restart impact.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants