batch jobs causes error message in stats_hook

[42wim]

Nomad version

0.9.4

Issue

Batch jobs causes ERROR message in stats_hook (even when they exit clean)

Aug 05 17:13:18 q-cloud nomad[125584]: 2019-08-05T17:13:18.444+0200 [ERROR] client.alloc_runner.task_runner.task_hook.stats_hook: failed to start stats collection for task with unrecoverable error: alloc_id=58b67839-0704-081e-b05c-3e39898d8461 task=batch-job error="container stopped"
Aug 05 17:13:18 q-cloud nomad[125584]: 2019-08-05T17:13:18.470+0200 [INFO ] client.alloc_runner.task_runner: not restarting task: alloc_id=58b67839-0704-081e-b05c-3e39898d8461 task=batch-job reason="Restart unnecessary as task terminated successfully"

[42wim]

same on 0.9.5

[msvbhat]

I'm seeing same error messages in 0.9.5. From what I can tell, it looks like a harmless message and may be it should not be logged as error?

[tgross]

It looks like this happens for all tasks, but it's just a lot more noticeable for batch jobs because they terminate as part of their regular operation. I agree with you @msvbhat that this is most likely over-zealous logging.

[erhlee-bird]

Confirming that this still happens.

• Nomad version: v0.10.2
• Parameterized Batch Jobs
• Docker Driver

[tgross]

Thanks @erhlee-bird. It definitely is a case where we're logging something that doesn't really need to be logged, especially as ERROR because it's going to happy literally every time an alloc stops. I've marked this issue for cleanup, but happy to take a PR if you have time to contribute too!

[stale]

Hey there

Since this issue hasn't had any activity in a while - we're going to automatically close it in 30 days. If you're still seeing this issue with the latest version of Nomad, please respond here and we'll keep this open and take another look at this.

Thanks!

[tgross]

I still want to fix this error message and haven't gotten around to it. I think adding the enhancement label will get stalebot to chill.

[tgross]

Sorry about the delay on such a trivial item. Will ship in 0.11.3.

[github-actions]

I'm going to lock this issue because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.