Allow dash in environment variable names

[lchayoun]

Fixes #6079

[hashicorp-cla]

All committers have signed the CLA.

[langmartin]

Thanks so much for the pr :) I think we may need to split apart the sanitizing code path a bit in order to allow hyphenated variables without changing existing behavior.

[langmartin]

Thanks so much for taking another pass at this! I'm going to get one more set of eyes on this to make sure the NOMAD_ namespace for environment variables is sufficiently baked in that it covers all the generate cases.

[lchayoun]

@langmartin after thinking about it a bit more, I think only generated environment variables should be cleaned.
I think use specified ones should be provided as specified.
Any issues with it?

[notnoop]

Thanks for submitting this. Fully agree that user set environment variables as set verbatim with no processing. Had a question about NOMAD_ prefix check heuristic but lgtm otherwise.

[lchayoun]

@notnoop I've added a specific list of the prefixes that needs to be cleaned, my only concern is for newly added generated environment variables prefixes that will need to be added to this list.
any ideas?

[lchayoun]

@notnoop any update on this PR?

[notnoop]

Thanks @lchayoun , sorry for taking too long to merge.

I'm less concerned about newly generated environment variables, considering that they don't have backward compatibility constraints like current ones. I'd follow up and add a comment for future contributors which I suspect is sufficient now.

[github-actions]

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.