Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alloc error message when no nodes are in DC #619

Merged
merged 3 commits into from
Jan 5, 2016
Merged

Alloc error message when no nodes are in DC #619

merged 3 commits into from
Jan 5, 2016

Conversation

dadgar
Copy link
Contributor

@dadgar dadgar commented Dec 22, 2015

Fixes #605

@c4milo
Copy link
Contributor

c4milo commented Dec 22, 2015

Looks good, although I would make failedMsg a constant to keep it consistent with the other allocation messages.

@c4milo
Copy link
Contributor

c4milo commented Dec 22, 2015

ah nevermind, I see now why you didn't do that.

@armon
Copy link
Member

armon commented Jan 4, 2016

LGTM!

dadgar added a commit that referenced this pull request Jan 5, 2016
Alloc error message when no nodes are in DC
@dadgar dadgar merged commit 8d110eb into master Jan 5, 2016
@dadgar dadgar deleted the f-dc-empty branch January 5, 2016 03:24
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants