Sorting State for Clients in UI is incorrect

[omada-jacob-smith]

Nomad version

Nomad v0.9.5+ent (5926e0d)

Operating system and Environment details

Ubuntu 18.04

Issue

Sorting of client's state (status) in UI is broken when mixed ineligible/ready clients.

Reproduction steps

1. Mark half of the clients ineligible
2. Drain clients from 1
3. After that has been finished, sorting of state will actually be by ID rather than state (status)

[stale]

Hey there

Since this issue hasn't had any activity in a while - we're going to automatically close it in 30 days. If you're still seeing this issue with the latest version of Nomad, please respond here and we'll keep this open and take another look at this.

Thanks!

[shantanugadgil]

message

[backspace]

Thanks for letting us know about this and I’m sorry for how long it took to respond. I found two causes for this:

1. The changes in Update client list to collapse statuses #5789 collapsed the status/draining/eligible columns into one but didn’t include anything about sorting. The column is called “state” but is still sorting on “status”.

   • (The nomenclature here is its own confusing thing; there’s also a compositeStatus that derives from those properties excluding isDraining.)

2. The Sortable mixin doesn’t declare the sort properties as dependent keys. Even when I made the sorting based on a new state property, changing the properties didn’t change the sort because of this.

I should be able to put together a PR to fix this tomorrow or next week. 💞

[backspace]

Thanks again for the report, the fix is now merged and it should be part of the next release, 0.10.3.

[github-actions]

I'm going to lock this issue because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.