Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zombie service registered if Service name is changed #658

Closed
calvn opened this issue Jan 7, 2016 · 8 comments
Closed

Zombie service registered if Service name is changed #658

calvn opened this issue Jan 7, 2016 · 8 comments

Comments

@calvn
Copy link
Member

calvn commented Jan 7, 2016

I encountered an issue where a Task was registered to Consul as service under a specific name, but after changing the name the old task name was still registered, in addition to the new one.

Initially I had this JSON Service object in the job spec:

...
"Services": [
  {
    "Name": "helloworld",
    "PortLabel": "http"
  }
],
...

Running this job registered the helloworld.service.dc1.consul service. I then changed the service name to be the following:

...
"Services": [
  {
    "Name": "nomad-helloworld",
    "PortLabel": "http"
  }
],
...

This registered nomad-helloworld.service.dc1.consul, but helloworld.service.dc1.consul was also still registered.

@diptanu
Copy link
Contributor

diptanu commented Jan 7, 2016

@cleung2010 This will be fixed in 0.3

@diptanu
Copy link
Contributor

diptanu commented Jan 7, 2016

I see we keep registering the service once it's name changes infinitely but we do remove the old service. So not sure why you are seeing a zombie service, we know the problem but taking some time to handle updates to allocations in a nicer way.

@calvn
Copy link
Member Author

calvn commented Jan 7, 2016

It seems that when I delete a job, the services on that job do not get deregistered. Don't know if this should be a separate issue.

Edit: Wrong API call on my part on this one, please disregard.

@diptanu
Copy link
Contributor

diptanu commented Jan 7, 2016

@cleung2010 Can you post your job description for that? I can't reproduce.

@calvn
Copy link
Member Author

calvn commented Jan 7, 2016

@diptanu regarding the job deletion? That's a mistake on my part, it's working as intended.

@diptanu
Copy link
Contributor

diptanu commented Jan 7, 2016

@cleung2010 Yeah I was asking about the job deletion. We know what's happening when the service name changes, a fix will land soon. Taking some time to handle updates properly.

@calvn
Copy link
Member Author

calvn commented Jan 12, 2016

@diptanu by zombie service I meant the state of the service registration and not the actual service (that service does get removed/replaced).

@github-actions
Copy link

I'm going to lock this issue because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants