Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup client GC endpoints to avoid using the GET method #6625

Open
langmartin opened this issue Nov 6, 2019 · 3 comments
Open

Cleanup client GC endpoints to avoid using the GET method #6625

langmartin opened this issue Nov 6, 2019 · 3 comments
Labels
theme/api HTTP API and SDK issues theme/cleanup

Comments

@langmartin
Copy link
Contributor

See #5970, where we avoid an EOF error on an empty GET response body. This prevents the error on the GC endpoints, but those endpoints should use an explicitly side-effecting method for clarity.

@langmartin langmartin added the theme/api HTTP API and SDK issues label Nov 6, 2019
@langmartin
Copy link
Contributor Author

The original issue fixed by #5970 is #5994

@langmartin langmartin self-assigned this Nov 19, 2019
@stale
Copy link

stale bot commented Feb 17, 2020

Hey there

Since this issue hasn't had any activity in a while - we're going to automatically close it in 30 days. If you're still seeing this issue with the latest version of Nomad, please respond here and we'll keep this open and take another look at this.

Thanks!

@tgross tgross modified the milestones: 0.10.4, 0.12.0, unscheduled Feb 18, 2020
@stale
Copy link

stale bot commented May 18, 2020

Hey there

Since this issue hasn't had any activity in a while - we're going to automatically close it in 30 days. If you're still seeing this issue with the latest version of Nomad, please respond here and we'll keep this open and take another look at this.

Thanks!

@tgross tgross added this to Needs Roadmapping in Nomad - Community Issues Triage Feb 12, 2021
@tgross tgross removed this from the unscheduled milestone Feb 12, 2021
@tgross tgross removed this from Needs Roadmapping in Nomad - Community Issues Triage Mar 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
theme/api HTTP API and SDK issues theme/cleanup
Projects
None yet
Development

No branches or pull requests

2 participants