-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support adding tags to sidecar consul entry #6642
Comments
Hi @dmwilcox! Thanks for opening this issue. Just to make sure I understand, you're referring to adding tags to the If so, I have good news! I dug around in the code and found that tags are supported but appear to have been missed in the documentation. If you're interested in contributing a patch to the Connect docs I'd be happy to help get that merged in quickly. Otherwise, I'll get that added soon. |
Adding tags to sidecar was planned for 0.10.1 but for reasons I don't know it was not included. |
Thanks for catching that @pashinin! I was looking in As for why it was moved into a later release: the 0.10.0 release had some panic-causing bugs under some upgrade scenarios. Rather than waiting until all the feature work was ready, the Nomad team decided to publish 0.10.1 as a bugfix release and renamed the planned release as 0.10.2. See the changelog for more details. |
Looks like the docs landed in #6455. Once that's published, they'll show up in https://www.nomadproject.io/docs/job-specification/sidecar_service.html |
I'm going to lock this issue because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active issues. |
Issue
Without being able to assign tags to the sidecar consul entry I cannot collect metrics using the consul datasource in prometheus.
Normally I set a tag, such as "port=25000", which during re-labeling modifies the prometheus scrape target. Without the ability to do that prometheus can only attempt to scrape the mTLS port.
The ideal way to do this would be to expose some options under the 'sidecar_service' stanza for configuring the sidecar. Very few fields are not permitted when using consul connect directly and tags would be a welcome addition for modifying scrape targets for prometheus and tagging logs (by way of consu' "key=value" type labels) with nomad_follower.
Happy to do some work on this if it isn't already in the works.
The text was updated successfully, but these errors were encountered: