Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vault: allow overriding implicit vault constraint #6687

Merged
merged 2 commits into from
Nov 12, 2019

Conversation

schmichael
Copy link
Member

There's a bug in version parsing that breaks this constraint when using
a prerelease enterprise version of Vault (eg 1.3.0-beta1+ent). While
this does not fix the underlying bug it does provide a workaround for
future issues related to the implicit constraint. Like the implicit
Connect constraint: all implicit constraints should be overridable to
allow users to workaround bugs or other factors should the need arise.

Tested locally with Vault 1.3.0-beta1+ent and:

job "hello" {
  datacenters = ["dc1"]

  group "echo" {
                constraint {
                        attribute = "${attr.vault.version}"
                        operator  = "is_set"
                    }

    task "echo" {

      driver = "raw_exec"
      config {
        command = "sleep"
        args = ["10000"]
      }

      vault {
        policies    = ["default"]
        change_mode = "restart"
      }

      resources {
        cpu    = 100
        memory = 100
        network {
          mbits = 10
        }
      }
    }
  }
}

@schmichael schmichael added this to the 0.10.2 milestone Nov 12, 2019
There's a bug in version parsing that breaks this constraint when using
a prerelease enterprise version of Vault (eg 1.3.0-beta1+ent). While
this does not fix the underlying bug it does provide a workaround for
future issues related to the implicit constraint. Like the implicit
Connect constraint: *all* implicit constraints should be overridable to
allow users to workaround bugs or other factors should the need arise.
@schmichael schmichael merged commit 1596a62 into master Nov 12, 2019
@schmichael schmichael deleted the f-override-vault-constraint branch November 12, 2019 20:47
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants