-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Please upgrade "go-hclog" library #6810
Comments
Nomad 0.10.2 vendors go-hclog@234833755cb25ae46996d0ef823326f492f89243, which is the same sha as the latest release v0.10.0. 😄. It looks like your problem comes from upgrading to a newer version of hashicorp/raft, where it changed from using golang's standard logger to go-hclog in #360. |
It appears that we have not yet tagged a release of hashicorp/raft since the inclusion of that PR however (https://github.com/hashicorp/raft/releases/tag/v1.1.1 is currently the latest) |
I first experienced this problem in 0.10.0 but before submitting this bug report I've reproduced it on current release 0.10.2.
Yes this is precisely my problem (which is actually a downstream problem in Debian where I maintain Nomad packages) but it is also your problem because eventually you'll have to upgrade the library sooner or later. Please keep such issues open until the problem is fixed. Denial helps nobody, you know... With 0.10.1 I used the following patch which no longer applies to 0.10.2:
|
@onlyjob FWIW I was going to upgrade Raft last night before realizing that there is no release with the new logging change yet - I'll make sure we file an issue to do so when a release is cut though. |
OK, thanks. This FTBFS is with raft-1.1.1 and go-hclog-0.10.0. Could you re-open this issue please? |
@endocrimes I'm going to reopen so that we can track that change has been merged for the 0.11.0 release. |
Looks like we needed bugfixes for 0.10.3. Merged in #6872 |
Thanks! :) |
Which branch |
Currently just |
|
I'm going to lock this issue because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active issues. |
Nomad 0.10.2 FTBFS with github.com/hashicorp/go-hclog >=0.9.2 as follows:
Please consider upgrading vendored library to latest released version.
Thanks.
The text was updated successfully, but these errors were encountered: