Fix panic when monitoring a local client node #7053
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drewbailey
force-pushed
the
b-client-monitor-acl-panic
branch
from
0adbe4c
to
b5795ef
Compare
notnoop
reviewed
Feb 3, 2020
drewbailey
force-pushed
the
b-client-monitor-acl-panic
branch
from
a1696da
to
23d3069
Compare
notnoop
approved these changes
Feb 3, 2020
drewbailey
force-pushed
the
b-client-monitor-acl-panic
branch
from
23d3069
to
e51c34a
Compare
schmichael
approved these changes
Feb 3, 2020
Fixes a panic when accessing a.agent.Server() when agent is a client instead. This pr removes a redundant ACL check since ACLs are validated at the RPC layer. It also nil checks the agent server and uses Client() when appropriate.
clean up logic and tests
drewbailey
force-pushed
the
b-client-monitor-acl-panic
branch
from
e8462d8
to
173ad83
Compare
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a panic when accessing a.agent.Server() when agent is a client
and not a server. This pr removes a redundant ACL check since ACLs are validated
at the RPC layer. It also nil checks the agent server and uses Client()
when appropriate.
fixes #7052