Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSI: Support for device mode volumes #7139

Closed
endocrimes opened this issue Feb 13, 2020 · 4 comments
Closed

CSI: Support for device mode volumes #7139

endocrimes opened this issue Feb 13, 2020 · 4 comments

Comments

@endocrimes
Copy link
Contributor

Currently we've only really been testing CSI for filesystem mounts and not devices.

We need to add support for mounting devices as part of shipping CSI. The "easiest" way to begin is probably "trying to run a job that requires one" repeatedly until you make it work, but the primary places to update will be:

  • taskrunner/volume_hook: This will need to generate drivers.DeviceConfig's for volumes where IsDevice is true. You'll also need to make sure these propagate to drivers correctly.
  • allocrunner/csi_hook: We may need to generate different paths for volumes that desire a device attachment mode.
@tgross
Copy link
Member

tgross commented Feb 14, 2020

I took a quick look through some of the CSI providers in kubernetes-sigs and it looks like BlockVolume (device) support isn't yet implemented for all the storage providers . I'm wondering if it might make sense for us to ship 0.11 with support only for MountVolume and then add BlockVolume support in a point release? Do you have a better understanding of whether this should be treated as a show-stopper?

@endocrimes
Copy link
Contributor Author

@tgross I'd personally be fine with deferring it but we should probably run that by @yishan-lin because the PRD had it as part of the success criteria so there may be some downstream communication required.

@tgross tgross self-assigned this Mar 17, 2020
@tgross tgross removed their assignment Mar 25, 2020
@schmichael schmichael removed this from the 0.11.0 milestone Apr 9, 2020
@tgross tgross added this to the unscheduled milestone Jul 9, 2020
@tgross
Copy link
Member

tgross commented Jul 24, 2020

Doing some issue cleanup. It looks like we've resolved this with the work we did to validate VolumeCapabilities in #7831 and fixing the target path in #8505, and I've had working tests with DO volumes in block-device mode. Going to close this out.

@tgross tgross closed this as completed Jul 24, 2020
@tgross tgross modified the milestones: unscheduled , 0.12.2 Jul 24, 2020
@github-actions
Copy link

github-actions bot commented Nov 4, 2022

I'm going to lock this issue because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants