Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dependencies on private consul packages #7205

Closed
drewbailey opened this issue Feb 20, 2020 · 3 comments
Closed

Remove dependencies on private consul packages #7205

drewbailey opened this issue Feb 20, 2020 · 3 comments
Labels
theme/consul theme/dependencies Pull requests that update a dependency file type/enhancement

Comments

@drewbailey
Copy link
Contributor

Issue

Nomad currently depends on a few non public packages from consul. Nomad should bring over what it needs into its own package

→ git grep '"github.com/hashicorp/consul[^-]' -- ':!vendor' ':!website' | grep -v "\bapi\b"  | grep -v "\btestutil\b" | cut -d':' -f2- | sort -u
        "github.com/hashicorp/consul/command/flags"
        "github.com/hashicorp/consul/lib"
        "github.com/hashicorp/consul/logging"
@drewbailey drewbailey added theme/consul theme/dependencies Pull requests that update a dependency file labels Feb 20, 2020
@drewbailey drewbailey added this to the 0.11.0 milestone Feb 20, 2020
@schmichael schmichael removed this from the 0.11.0 milestone Apr 9, 2020
@stale
Copy link

stale bot commented Jul 9, 2020

Hey there

Since this issue hasn't had any activity in a while - we're going to automatically close it in 30 days. If you're still seeing this issue with the latest version of Nomad, please respond here and we'll keep this open and take another look at this.

Thanks!

@tgross
Copy link
Member

tgross commented Oct 4, 2022

Closed (finally) by #14441

@tgross tgross closed this as completed Oct 4, 2022
@github-actions
Copy link

github-actions bot commented Feb 3, 2023

I'm going to lock this issue because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
theme/consul theme/dependencies Pull requests that update a dependency file type/enhancement
Projects
None yet
Development

No branches or pull requests

3 participants