Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow shutdown_delay to execute regardless of service registration #7271

Closed
drewbailey opened this issue Mar 4, 2020 · 4 comments · Fixed by #7663
Closed

Allow shutdown_delay to execute regardless of service registration #7271

drewbailey opened this issue Mar 4, 2020 · 4 comments · Fixed by #7663

Comments

@drewbailey
Copy link
Contributor

drewbailey commented Mar 4, 2020

Issue

Currently a task's shutdown_delay as well as the task group's shutdown delay will only run if there are registered services for the task or group.

This implementation detail isn't called out anywhere in the documentation and the way that its configured, by setting shutdown_delay outside of the service block makes it unclear that shutdown_delay is dependent on a service.

Original report: #7251

@djenriquez
Copy link

@drewbailey -- Just to clarify, if we use network namespaces, and subsequently group level service definitions, then only the group level shutdown_delay will go into effect. The task's shutdown_delay will be ignored since there is no service defined at that level.

Is this a true statement?

@drewbailey
Copy link
Contributor Author

Hey @djenriquez, that is correct. Currently a task needs to have a service defined in order for a task shutdown_delay to be evaluated or even created here. The service hooks preKilling method is what invokes shutdown_delay

@djenriquez
Copy link

Understood, thank you for the very prompt response!

@github-actions
Copy link

github-actions bot commented Nov 8, 2022

I'm going to lock this issue because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants