Client only pulls update allocations from server #731
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dadgar
force-pushed
the
f-reduce-client-alloc-pulls
branch
from
4fb09c4
to
4322509
Compare
dadgar
force-pushed
the
f-reduce-client-alloc-pulls
branch
from
f13c04d
to
3b90539
Compare
| @@ -184,6 +187,8 @@ func (r *AllocRunner) DestroyContext() error { | |||
|
|
|||
| // Alloc returns the associated allocation | |||
| func (r *AllocRunner) Alloc() *structs.Allocation { | |||
| r.allocLock.Lock() | |||
There was a problem hiding this comment.
Why do we need to acquire a lock here? I don't see us mutating anything here. Does the caller expects the alloc to not change once it has? We should probably make a copy and return if that's the assumption, otherwise the alloc might change under the hood once the caller has it.
dadgar
added a commit
that referenced
this pull request
Feb 2, 2016
Client only pulls update allocations from server
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the client would pull all its allocations whenever the modify index of an allocation that should be running on it changed.
This PR modifies the client to track how many updates have occurred locally to the running alloc and then only pulls a lightweight list of allocation ids to modify indexes from the server. It uses this to decide whether an updated version of the allocation needs to be pulled from the server.
This reduces network traffic when the client updates allocs to the server.