-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Alloc Health should take Group Checks into Consideration #7375
Comments
I have tested the code and it looks we properly account for service check health. The group checks get presented as associated with a "fake" task with the group name as the task name. The relevant bits are:
[2] nomad/client/allocrunner/groupservice_hook.go Lines 192 to 206 in 2949c44
[3] nomad/command/agent/consul/client.go Line 942 in 2949c44
[4] nomad/command/agent/consul/structs.go Lines 88 to 94 in 2949c44
Not sure I fully understand the TODO in code referenced in the issue. Group services don't have task health associated with them. But should they? Should we track the envoy/sidecar containers as task health? Task health differ from checks as they simply check if the task is running. |
Also, we probably should document that consul registrations may contain synthetic tasks not present in job description - it'd be an easy mistake to make - like I've done in https://github.com/hashicorp/nomad/pull/7366/files . |
I'm going to lock this issue because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active issues. |
This code comment is incorrect:
nomad/client/allochealth/tracker.go
Lines 241 to 246 in 0ecda99
Group checks are supported and should be taken into consideration when setting allocation health.
The text was updated successfully, but these errors were encountered: