Default/Validate resources. #739
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -619,6 +619,10 @@ func parseResources(result *structs.Resources, list *ast.ObjectList) error { | |||
| result.Networks = []*structs.NetworkResource{&r} | |||
| } | |||
|
|
|||
| // Combine the parsed resources with a default resource block. | |||
| min := structs.DefaultResources() | |||
There was a problem hiding this comment.
I think this logic should be in the jobs endpoint? Users who are submitting the jobs via the http API can optionally get the default resources if they don't specify
There was a problem hiding this comment.
Talked about defaulting with Armon a bit and the consensus is the api endpoint should do as little defaulting as possible
dadgar
force-pushed
the
f-min-resources
branch
from
2ea2ec0
to
7ea6619
Compare
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds validation to the resources and default the CPU/Mem/Disk/IOPS resources.