Parse security_opts before sending them to docker daemon #7554
Conversation
|
|
benbuzbee
force-pushed
the
benbuz/fix-seccomp-file
branch
from
6a37b45
to
d689a75
Compare
| func TestDockerDriver_SecurityOptFromFile(t *testing.T) { | ||
| seccompPath := "./test-resources/docker/seccomp.json" | ||
|
|
||
| if runtime.GOOS == "windows" { |
There was a problem hiding this comment.
You can also move the test to driver_unix_test.go (or driver_linux_test.go) instead if it doesn't apply to Windows. Does it apply to macOS?
There was a problem hiding this comment.
Honestly not sure. I copied the boiler plate from the existing seccomp=unconfined test. I would have thought even windows would run the container in a VM where seccomp applies but I have no good way to test.
There was a problem hiding this comment.
Makes sense - I'll test behavior!
Fixes hashicorp#6720 Copy the parsing function from the docker CLI. Docker daemon expects to see JSON for seccomp file not a path.
benbuzbee
force-pushed
the
benbuz/fix-seccomp-file
branch
from
d689a75
to
a3c3f7e
Compare
|
Thank you so much @benbuzbee - this fix should be out in 0.11.0! |
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Fixes #6720
Copy the parsing function from the docker CLI. Docker daemon expects to see JSON for seccomp file not a path.