Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tmp folder to each task directory #757

Merged
merged 1 commit into from
Feb 5, 2016
Merged

Add tmp folder to each task directory #757

merged 1 commit into from
Feb 5, 2016

Conversation

dadgar
Copy link
Contributor

@dadgar dadgar commented Feb 4, 2016

Add tmp file to each task directory

@dadgar dadgar changed the title Add tmp file to each task directory Add tmp folder to each task directory Feb 4, 2016
@diptanu
Copy link
Contributor

diptanu commented Feb 5, 2016

LGTM

dadgar added a commit that referenced this pull request Feb 5, 2016
Add tmp folder to each task directory
@dadgar dadgar merged commit f2b9e18 into master Feb 5, 2016
@dadgar dadgar deleted the f-tmp branch February 5, 2016 01:21
@rejeep
Copy link

rejeep commented Apr 4, 2017

Hi,

I ran into an issue using the /tmp directory. We are using the exec driver and the code running in there is Ruby.

We are trying to use the method Dir.mktmpdir, but it fails. Looking at the implementation it expects the /tmp directory to be sticky, which it's not currently.

def Dir::tmpdir
  if $SAFE > 0
    tmp = @@systmpdir
  else
    tmp = nil
    for dir in [ENV['TMPDIR'], ENV['TMP'], ENV['TEMP'], @@systmpdir, '/tmp', '.']
      next if !dir
      dir = File.expand_path(dir)
      if stat = File.stat(dir) and stat.directory? and stat.writable? and
          (!stat.world_writable? or stat.sticky?)
        tmp = dir
        break
      end rescue nil
    end
    raise ArgumentError, "could not find a temporary directory" if !tmp
    tmp
  end
end

What do you say about setting the sticky attribute?

@dadgar
Copy link
Contributor Author

dadgar commented Apr 4, 2017

@rejeep #2519. Thanks for letting us know!

@rejeep
Copy link

rejeep commented Apr 4, 2017

@dadgar Thanks for fixing it! 👍

@github-actions
Copy link

github-actions bot commented Apr 2, 2023

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants