Fixes bug that prevented group shutdown_delay updates #7618
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
notnoop
reviewed
Apr 3, 2020
Group shutdown delay updates were not properly handled in Update hook. This commit also ensures that plan output is displayed.
drewbailey
force-pushed
the
b-shutdown-delay-updates
branch
from
39bfe4b
to
b81a001
Compare
schmichael
approved these changes
Apr 6, 2020
drewbailey
force-pushed
the
b-shutdown-delay-updates
branch
from
c53ef9a
to
a142302
Compare
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Group shutdown delay updates were not properly handled in Update hook.
This commit also ensures that plan output is displayed.
This issue originally was to fix #7265 but ran into issue testing where updates to shutdown_delay were not persisted either.
fixes #7265