Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ar/bridge_networking: ensure cni configuration is loaded #7643

Merged
merged 4 commits into from
Apr 7, 2020
Merged

Conversation

nickethier
Copy link
Member

After a client restart, a recovered alloc would never load cni configuration necessary for cleanly destroying it. This PR ensures that cni configuration is loading during both Setup and Teardown.

fixes #7537

Copy link
Member

@schmichael schmichael left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed the fix! 🎉

@schmichael schmichael merged commit ecbb2fa into master Apr 7, 2020
@schmichael schmichael deleted the b-7537 branch April 7, 2020 03:25
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Restart of Nomad Client causes port forwarding issues upon restart of running Connect jobs
3 participants