Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSI: show a useful error for on schedule / job validation for incompatible task drivers #7774

Closed
tgross opened this issue Apr 22, 2020 · 3 comments · Fixed by #8030
Closed

Comments

@tgross
Copy link
Member

tgross commented Apr 22, 2020

Task drivers like QEMU can't support CSI, so we should show a useful error to the operator when they try to schedule a job (or validate one), rather than erroring-out at the client.

@tgross tgross added this to the 0.11.2 milestone Apr 22, 2020
@tgross tgross modified the milestones: 0.11.2, 0.11.3 May 13, 2020
@tgross
Copy link
Member Author

tgross commented May 15, 2020

I tested this out a bit and it looks like QEMU doesn't support host volumes either. But because there's no checking, the jobspec will let you configure it and it just won't work (the volume isn't mounted).

So I'm wondering whether we should add a new field to the Driver Capabilities struct so that we can test this as part of task driver fingerprinting. It would need to be backwards-compatible with existing fields, so maybe something like VolumeSupport as an enum that defaults to "all" but has a "host volumes only" (is that a thing?) and a "none" option.

@angrycub
Copy link
Contributor

I believe that I ran into this with the java driver on macOS because it doesn't have FSIsolation as well.

@github-actions
Copy link

github-actions bot commented Nov 7, 2022

I'm going to lock this issue because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants