Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reduce running goroutines for volumewatcher #7837

Closed
tgross opened this issue Apr 30, 2020 · 1 comment · Fixed by #7909
Closed

reduce running goroutines for volumewatcher #7837

tgross opened this issue Apr 30, 2020 · 1 comment · Fixed by #7909

Comments

@tgross
Copy link
Member

tgross commented Apr 30, 2020

In #7794, @langmartin pointed out:

For the long term, I'm a little worried about starting a go routine for every volume. It seems at least possible that some operators could set us up for more goroutines than we want running for these, maybe in a followup if warranted we could use a fixed pool?

For large clusters with many volumes we could end up with a lot of extra running goroutines. We could reduce this with a fixed pool. But we may also be able to simply Stop() the watch goroutine when we've completed processing an incoming update, when we've determined either there are no more past claims to process or no more claims at all).

@tgross tgross added this to the 0.11.2 milestone Apr 30, 2020
@tgross tgross self-assigned this Apr 30, 2020
@tgross tgross changed the title use a goroutine work pool for volumewatcher reduce running goroutines for volumewatcher Apr 30, 2020
@github-actions
Copy link

github-actions bot commented Nov 7, 2022

I'm going to lock this issue because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant