Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add batch maximum to volume/deployment watcher #7838

Closed
tgross opened this issue Apr 30, 2020 · 2 comments
Closed

add batch maximum to volume/deployment watcher #7838

tgross opened this issue Apr 30, 2020 · 2 comments
Assignees
Milestone

Comments

@tgross
Copy link
Member

tgross commented Apr 30, 2020

In #7794, @langmartin pointed out that the volume watcher's batcher doesn't have a maximum batch size. This code was lifted from our deployment watcher, so we're missing that there as well. In practice, the batch window is only 250ms so the batch sizes never get large enough with deployment watcher for it to become an issue. But it might be with large jobs for volume watcher, and it's a good safety/robustness check.

@tgross
Copy link
Member Author

tgross commented May 8, 2020

Closed by #7907

@github-actions
Copy link

github-actions bot commented Nov 7, 2022

I'm going to lock this issue because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant