-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CSI: Add ControllerJob and NodeJob to the Plugin API response #7974
Comments
The UI would use this for #7969 |
There's one hiccup with this: more than one job and version can define a node plugin or controller plugin. It definitely seems like a weird case, but there are a couple of examples where you might see this:
|
It occurs to me that this is a problem with the existing API as well and frankly with the data model we have; we define plugins by fingerprinting the jobs so that updates to jobs update the plugin definition as well. So maybe my concern isn't a problem we need to worry about. |
This doesn't actually turn out to help the UI reduce the number of queries, so the API change is omitted. |
I'm going to lock this issue because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active issues. |
It would be nice to be able to link from a CSI plugin to the jobs that power the plugin.
This is technically currently possible by doing the following:
If the plugin response also had this job information (JobID, JobNamespace, JobVersion) then we can save a step.
I'm imagining six new properties on the Plugin, but since some of these may only be applicable for CSI Plugins, I don't think I'm the best judge on API design.
The text was updated successfully, but these errors were encountered: