Canary AutoPromote fails when non-canary taskgroups exist

[djenriquez]

Nomad version

Output from nomad version

nomad version
Nomad v0.11.2 (807cfebe90d56f9e5beec3e72936ebe86acc8ce3)

Operating system and Environment details

Amazon Linux 2

Issue

When canary deploys are mixed with non-canary deploys, auto-promote defaults to false.

This should consider the deployment process for each taskgroup and realize that, if each taskgroup were its own job, each would autopromote successfully.

The deployer should only set autopromote for the job to false IF there exists a taskgroup where canary > 0 AND autopromote == false. Otherwise, if all taskgroups where canary > 0 && autopromote == true, the entire job should autopromote.

In the above screenshot, taskgroups 1,2, and 5 have canary = 1 and autopromote = true. Taskgroups 3 and 4 are configured for rolling deploys. All taskgroups succeed their deployment, but the job still requires a manual promotion.

I believe this is because the rolling deploys need to be configured with autopromote = false, otherwise we get a warning message:

rpc error: 1 error occurred: * Task group <REDACTED> validation failed: 1 error occurred: * 1 error occurred: * Auto Promote requires a Canary count greater than zero

but since this is a rolling deploy taskgroup, we cannot set Canary > 0.

Reproduction steps

1 Job, 2 Taskgroups

1. Create a job with 2 taskgroups
2. Define one taskgroup as a canary deploy /w autopromotion
3. Define the other taskgroup as a rolling deploy
4. Make a change to the job config to trigger a deployment

2 Jobs, 1 Taskgroup (separated)

1. Separate the job into two with one taskgroup each
2. Perform a deploy on each job and watch each job deploy to completion

In summary, if each taskgroup were separated into separate jobs and can complete a deployment on its own, then a job that is a collection of those same taskgroups should also behave the same way.

[github-actions]

I'm going to lock this issue because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.