Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support PreserveCounts in job registration API #8158

Closed
cgbaker opened this issue Jun 12, 2020 · 2 comments · Fixed by #8168
Closed

Support PreserveCounts in job registration API #8158

cgbaker opened this issue Jun 12, 2020 · 2 comments · Fixed by #8168
Assignees
Labels
theme/api HTTP API and SDK issues theme/autoscaling Issues related to supporting autoscaling
Milestone

Comments

@cgbaker
Copy link
Contributor

cgbaker commented Jun 12, 2020

As part of the scaling API work, we planned to add a query parameter payload parameter, PreserveCounts: bool = false, to job registration, indicating that existing task group counts should be preserved, taken precedence over any counts included in the job spec in the update payload. This allows, e.g., CD scripts to more easily update job definition without conflicting with changes to made to the count by an autoscaler.

@cgbaker cgbaker added theme/api HTTP API and SDK issues theme/autoscaling Issues related to supporting autoscaling labels Jun 12, 2020
@cgbaker cgbaker self-assigned this Jun 12, 2020
@cgbaker cgbaker added this to the 0.12.0 milestone Jun 12, 2020
@cgbaker cgbaker changed the title Support ignore-counts in job registration API Support preserve_counts in job registration API Jun 12, 2020
@jippi
Copy link
Contributor

jippi commented Jun 13, 2020

Huge +1 on this - it's an annoying repetitive thing we repeat a lot in our SeatGeek tooling as well

@cgbaker cgbaker changed the title Support preserve_counts in job registration API Support PreserveCounts in job registration API Jun 16, 2020
@github-actions
Copy link

github-actions bot commented Nov 6, 2022

I'm going to lock this issue because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
theme/api HTTP API and SDK issues theme/autoscaling Issues related to supporting autoscaling
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants