Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve handling of invalid multiregion deploys vs OSS #8200

Closed
tgross opened this issue Jun 18, 2020 · 3 comments · Fixed by #8687
Closed

improve handling of invalid multiregion deploys vs OSS #8200

tgross opened this issue Jun 18, 2020 · 3 comments · Fixed by #8687

Comments

@tgross
Copy link
Member

tgross commented Jun 18, 2020

If you run a multiregion job against an OSS region, the current behavior is that the deployment gets stuck in pending and you need to fix your jobspec to continue. We didn't have this error-out because we were concerned about what would happen in a ENT cluster was downgraded to OSS, leaving jobs in the state store with multiregion stanzas.

We need to:

  • improve the messaging to the operator around this case (at least return a warning!)
  • document the behavior
  • see if we can come up with way to reject the job safely without breaking the downgraded cluster use case.
@tgross tgross self-assigned this Jun 19, 2020
@tgross tgross changed the title improve handling of improper multiregion deploys vs OSS improve handling of invalid multiregion deploys vs OSS Jun 19, 2020
@tgross
Copy link
Member Author

tgross commented Aug 18, 2020

It looks like the ENT->OSS downgrade case isn't something we support, so that simplifies the problem quite a bit. We'll pull the (*Multiregion) Validate() method into ENT and just have it return an error if non-nil in OSS.

@tgross
Copy link
Member Author

tgross commented Aug 18, 2020

Will ship in 0.12.4

@github-actions
Copy link

github-actions bot commented Nov 3, 2022

I'm going to lock this issue because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant