Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: Reset the system and refetch namespaces with every token change #8413

Merged
merged 2 commits into from
Jul 10, 2020

Conversation

DingoEatingFuzz
Copy link
Contributor

Fixes #6492

Curiously, when I attempted to fix the reported issue, I couldn't find the root cause. For some reason, despite the namespace being in localStorage and in the system service, it couldn't be looked up via this.get('system.activeNamespace.id'). It would just be undefined. More curious yet, this.get('system.activeNamespace').id worked.

While poking at that, I noticed that the namespaces list would be stale after a token change, since different tokens will allow access to different sets of namespaces. Fixing that issue coincidentally fixed the reporting issue. I'll take it ¯_(ツ)_/¯

@github-actions
Copy link

github-actions bot commented Jul 10, 2020

Ember Asset Size action

As of da02410

Files that got Bigger 🚨:

File raw gzip
nomad-ui.js +60 B +10 B

Files that stayed the same size 🤷‍:

File raw gzip
vendor.js 0 B 0 B
nomad-ui.css 0 B 0 B
vendor.css 0 B 0 B

@github-actions
Copy link

github-actions bot commented Jul 10, 2020

Ember Test Audit comparison

master da02410 change
passes 1287 1288 +1
failures 0 0 0
flaky 0 0 0
duration 5m 55s 751ms 6m 00s 788ms +05s 037ms

Copy link
Contributor

@backspace backspace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for figuring this out! That’s a strange discrepancy with the property being undefined but I’m glad the problem disappeared with the clearing of namespaces 🥳

@DingoEatingFuzz DingoEatingFuzz merged commit 99fce00 into master Jul 10, 2020
@DingoEatingFuzz DingoEatingFuzz deleted the b-ui/namespaces-after-token branch July 10, 2020 22:29
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UI: Jobs queries aren’t namespaced after setting a token
2 participants