drivers: validate that command contains one field

[dadgar]

Drivers that support a command field now validate that a single input is given.

[diptanu]

LGTM

[ranjib]

for docker images which has entrypoint /cmd specified in the dockerfile/metadata, this will not cause failure? or we expect to enforce passing command explicitly, always ?

[diptanu]

@ranjib This shouldn't cause any issues with entrypoint stuff. This only throws an error if you have spaces in the Command key in the docker driver config.

[ninoles]

Is there any way to pass a command with space in it ? If that's not allowed, the warning should happen far before the driver execution and correctly documented.

Ideally, you should not simply do a lookup on space, but a full quoting check.

[dadgar]

@ninoles Are you trying to do something like foo | bar > baz? If so your config should be:

command = "bash"
args = ["-c", "foo | bar > baz"]

[ninoles]

#No, I'm trying to start "C:\Program Files\Python35\python.exe". I could push out to cmd.exe or powershell, but that's not ideal. I could also put the binary path in an environment variable and set command with it (the validation happen BEFORE variable replacement in the case of exec and raw_exec driver).

Also, one problem with it is the error report is confusing: "C:\Program Files\Python35\python.exe" doesn't have any arguments, so why it complains about it ?

In the end, I think the validation shouldn't happen, or at least shouldn't be an error. The config format is very well suited for supporting space in executable path, so why not allowing it ?

I open a bug in this regard: #1737

[github-actions]

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.