Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align ux across nomad alloc sub commands #8450

Closed
drewbailey opened this issue Jul 16, 2020 · 3 comments · Fixed by #10026
Closed

Align ux across nomad alloc sub commands #8450

drewbailey opened this issue Jul 16, 2020 · 3 comments · Fixed by #10026

Comments

@drewbailey
Copy link
Contributor

drewbailey commented Jul 16, 2020

Ensure swapping subcommands (exec/logs) allows for a consistent and predictable user experience.

nomad alloc exec requires a an allocation id, and if the allocation has multiple tasks a -task flag.

nomad alloc exec -task=task-name <alloc> /bin/sh

nomad alloc logs allows for a second param for the task

nomad alloc logs <alloc> task

@mr-karan
Copy link
Contributor

@drewbailey I'd want to pick this up if no one's working on it :)

Just to confirm, the desired behaviour should be:

nomad alloc exec -task=task-name <alloc>
nomad alloc logs -task=task-name <alloc>

Does this seem correct?

@drewbailey
Copy link
Contributor Author

Hey @mr-karan, that's great! I don't believe anyone is currently working on this already.

Preserving backwards compatibility is the main thing with this issue, so I think your proposed solution works.

nomad alloc exec is unchanged, nomad alloc logs gets a new optional -task flag. We'll probably want to ensure that -task=task-name and nomad alloc logs <alloc> <task> work together as well

@tgross tgross added this to Needs Roadmapping in Nomad - Community Issues Triage Feb 12, 2021
Nomad - Community Issues Triage automation moved this from Needs Roadmapping to Done Feb 16, 2021
@github-actions
Copy link

I'm going to lock this issue because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants