Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deregister creates an unnecessary Eval if job doesn't exist #8464

Closed
notnoop opened this issue Jul 20, 2020 · 1 comment
Closed

Deregister creates an unnecessary Eval if job doesn't exist #8464

notnoop opened this issue Jul 20, 2020 · 1 comment

Comments

@notnoop
Copy link
Contributor

notnoop commented Jul 20, 2020

When deregistering a job, Nomad explicitly creates an Evaluation if the job doesn't exist. It's unclear why this is the case, and it seems a bit wasteful.

The behavior was introduced without much context in #981, and is masked as an improvement in the changelog.

It's unclear what the benefit of the behavior is. We speculate that it is bandaid around an deregistering atomicity bug, or to ensure idempotency of deregistration (e.g. re-deregister job should always succeed).

This lead to a discussion in #8435 (comment) as it complicated the handling of atomic job deregistration logic.

Investigate further and act accordingly.

@tgross
Copy link
Member

tgross commented Jun 28, 2024

Doing a little bit of old issue cleanup. This was fixed as a side note of #16287, which was released in Nomad 1.5.1

@tgross tgross closed this as completed Jun 28, 2024
@tgross tgross added this to the 1.5.1 milestone Jun 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

No branches or pull requests

2 participants