UI: Always add the active region as a query param to API requests

[DingoEatingFuzz]

Fixes #7309 #8195

This was a straightforward fix but it shone a light on a pretty big test coverage gap. As a consequence, most of this diff is new tests and test refactoring.

Root issue
The root issue is a sorta clumsy intersection of a few truths and a lack of testing on our part.

1. To make cross-region API requests, the url requested must always include the region query parameter.
2. Using query params with PUT, POST, and DELETE requests is unorthodox. Typically if a request has a request body, it doesn't also have query params.
3. Given this convention, Ember (first by way of jquery, now by way of backwards compatibility) assumes anything passed in as data will be encoded as query params for GET requests and as requestBody properties for all other requests.
4. Without our own intervention, regions were being encoded in the requestBody erroneously instead of as a query param.

Resolution
All API requests going through Ember Data eventually hit the ajaxOptions method of the application adapter. This is already where the region param handling was happening. Now instead of stuffing the property in the data hash, it is manually appended to the URL as a query param.

All API requests going through the token service were unaffected since the region was already manually being added as a query param.

To ensure this is true everywhere and to set a precedent going forward, unit tests for all adapter actions now include variations for use with a non-default region. This includes

1. Job
   1. fetchRawDefinition
   2. forcePeriodic
   3. stop
   4. parse
   5. plan
   6. run
   7. update
   8. scale
2. Allocation
   1. stop
   2. restart
   3. `ls
   4. stat
3. Deployment
   1. promote
4. Node
   1. setEligible
   2. setIneligible
   3. drain
   4. forceDrain
   5. cancelDrain

[github-actions]

Ember Asset Size action

As of 544d941

Files that got Bigger 🚨:

File	raw	gzip
nomad-ui.js	+103 B	+41 B

Files that stayed the same size 🤷‍:

File	raw	gzip
vendor.js	0 B	0 B
nomad-ui.css	0 B	0 B
vendor.css	0 B	0 B

[github-actions]

Ember Test Audit comparison

	master	544d941	change
passes	1290	1315	+25
failures	0	0	0
flaky	0	0	0
duration	6m 00s 130ms	6m 30s 159ms	+30s 029ms

[backspace]

I have a couple of minor comments but nothing blocking. I didn’t run this locally but I did check it out on Netlify with mirage-logging=true and all looks well 😀

[backspace]

A nice clean intervention! 😍

[backspace]

Quite minor but it looks like this isn’t accessed anywhere in this test 🤓

[DingoEatingFuzz]

Good catch!

[backspace]

I’m not sure this would work but I wonder if this repeated setup step could be extracted with something like this inside testCases.forEach:

if (testCase.region) {
  hooks.beforeEach(function() {
    window.localStorage.nomadActiveRegion = testCase.region;
  });
}

Maybe it’s not worth it though, since there would still be other boilerplate-ish things shared between tests.

[DingoEatingFuzz]

I tried this and it did not work. I think since tests can run in any order, the only way to make this work is to give each test case its own module...but I'm gonna avoid the nerd snipe 😅

[github-actions]

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.